chore(ci): Report diff in _diff:fail in GitHub Actions
#6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
requested changes
Jan 23, 2025
jsoref
force-pushed
the
ci-diff-fail-summary
branch
from
2a6b928 to
997684a
Compare
|
Fwiw, there are a number of other one-liners in that file which probably should also be migrated... I generally follow when-in-Rome, and this file didn't have a strong pattern discouraging inline scripts (I personally don't like them and would definitely not have introduced it if things looked differently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI does a lot of work to generate output, it's a shame to just throw it all away and say "hey, you need to do something".
With this change, you can get the output in a format that you can then apply:
https://github.com/check-spelling-sandbox/opentelemetry.io/actions/runs/12887761281#summary-35931140960