Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting CAMS variables programmatically #36

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

jacobbieker
Copy link
Member

Pull Request

Description

This allows us to set variables programmatically to download for CAMS forecasts.

Fixes #

How Has This Been Tested?

Test runs

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker self-assigned this Nov 28, 2023
@jacobbieker jacobbieker requested a review from devsjc November 28, 2023 09:15
Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that you don't need to modify the config dict CAMSConfig at all - is that what the PermissiveConfig thing does? Lets you modify config.dict() behind the scenes?

@jacobbieker
Copy link
Member Author

Interesting that you don't need to modify the config dict CAMSConfig at all - is that what the PermissiveConfig thing does? Lets you modify config.dict() behind the scenes?

Yeah, the docs say it allow for arbitrary keys https://docs.dagster.io/_apidocs/config that you can access later. Would have made it more explicit, but to have it work easily for both EU CAMS and Global CAMS, seemed easier for it to be just extra keywords

@jacobbieker jacobbieker merged commit b80f250 into main Nov 28, 2023
4 checks passed
@devsjc devsjc deleted the jacob/cams-config branch November 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants