add UKV #226
Draft
add UKV #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first try at this @devsjc, I wonder if you could have a look and advise |
devsjc
requested changes
Jan 22, 2025
src/nwp_consumer/internal/repositories/raw_repositories/mo_datahub.py
Outdated
Show resolved
Hide resolved
|
A great first effort Peter! Hopefully it wasn't too much of a pain to figure out, I like to think the model API is fairly self-explanatory, but its certainly easy for me to say...! |
devsjc
approved these changes
Jan 22, 2025
devsjc
reviewed
Jan 22, 2025
| case self.WIND_DIRECTION.name: | ||
| return ParameterData( | ||
| name=str(self), | ||
| description="The wind direction from 0 to 360", |
There was a problem hiding this comment.
Can you specify that 0 is north just for complete clarity? I've tried to be as explicit as possible in all the other descriptions.
devsjc
requested changes
Jan 22, 2025
| Parameter.DOWNWARD_SHORTWAVE_RADIATION_FLUX_GL, | ||
| Parameter.TEMPERATURE_SL, | ||
| Parameter.WIND_U_COMPONENT_10m, | ||
| Parameter.WIND_V_COMPONENT_10m, | ||
| Parameter.WIND_DIRECTION, |
There was a problem hiding this comment.
Can you also put a height at the end? Is it WIND_DIRECTION_10m for instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add UKV MO model. This has x and y as main dims, with lat and lot as a grid.
Current we have dropped lat and lon, but perhaps it would be good to save these too TODO
We might need to add #222 so that not data is not pulled twice
openclimatefix/ocf-infrastructure#697
How Has This Been Tested?
Checklist: