Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pvlive 1.4.0 and fix nighttime zeros #96

Merged
merged 9 commits into from
Dec 18, 2024
Merged

use pvlive 1.4.0 and fix nighttime zeros #96

merged 9 commits into from
Dec 18, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 18, 2024 •
edited
Loading

Pull Request

Description

  • update to pvlive 1.4.0, and use new url
  • fix timestamps for nitghtime zeros
  • tidy up docker

Fixes #

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield mentioned this pull request Dec 18, 2024
Open
@peterdudfield peterdudfield changed the title use pvlive 1.4.0 ad use correct url use pvlive 1.4.0 and fix nighttime zeros Dec 18, 2024
@peterdudfield peterdudfield requested a review from braddf December 18, 2024 17:37
@peterdudfield peterdudfield merged commit 0844305 into main Dec 18, 2024
2 checks passed
@peterdudfield peterdudfield deleted the issue/nighttime-fix branch December 18, 2024 20:07
@peterdudfield
Copy link
Contributor Author

I decided to merge, to test it out, but please add any comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddf braddf Awaiting requested review from braddf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield