create explicit elastic index mappings, address PPR review

packages/client/src/v2-events/features/events/useEventConfiguration.ts

@@ -20,12 +20,6 @@ export function useEventConfigurations() {
   return config
 }
 
-export function getAllFields(configuration: EventConfig) {
-  return configuration.actions
-    .flatMap((action) => action.forms.filter((form) => form.active))
-    .flatMap((form) => form.pages.flatMap((page) => page.fields))
-}
-
 /**
  * Fetches configured events and finds a matching event
  * @param eventIdentifier e.g. 'birth', 'death', 'marriage' or any configured event

packages/client/src/v2-events/features/workqueues/EventOverview/EventOverview.tsx

@@ -14,14 +14,14 @@ import { useTypedParams } from 'react-router-typesafe-routes/dom'
 import {
   ActionDocument,
   EventIndex,
+  getAllFields,
   SummaryConfig
 } from '@opencrvs/commons/client'
 import { Content, ContentSize } from '@opencrvs/components/lib/Content'
 import { IconWithName } from '@client/v2-events/components/IconWithName'
 import { ROUTES } from '@client/v2-events/routes'
 
 import {
-  getAllFields,
   useEventConfiguration,
   useEventConfigurations
 } from '@client/v2-events/features/events/useEventConfiguration'

packages/commons/src/events/DeduplicationConfig.ts

@@ -27,9 +27,11 @@ const FuzzyMatcher = Matcher.extend({
   type: z.literal('fuzzy'),
   options: z
     .object({
-      // Names of length of 3 or less characters = 0 edits allowed
-      // Names of length of 4 - 6 characters = 1 edit allowed
-      // Names of length of >7 characters = 2 edits allowed
+      /**
+       * Names of length 3 or less characters = 0 edits allowed
+       * Names of length 4 - 6 characters = 1 edit allowed
+       * Names of length >7 characters = 2 edits allowed
+       */
       fuzziness: z
         .union([z.string(), z.number()])
         .optional()

packages/commons/src/events/utils.ts

@@ -13,7 +13,7 @@ import { TranslationConfig } from './TranslationConfig'
 
 import { EventMetadataKeys, eventMetadataLabelMap } from './EventMetadata'
 import { flattenDeep } from 'lodash'
-import { EventConfigInput } from './EventConfig'
+import { EventConfig, EventConfigInput } from './EventConfig'
 import { SummaryConfigInput } from './SummaryConfig'
 import { WorkqueueConfigInput } from './WorkqueueConfig'
 import { FieldType } from './FieldConfig'
@@ -100,3 +100,9 @@ export const resolveFieldLabels = ({
     })
   }
 }
+
+export function getAllFields(configuration: EventConfig) {
+  return configuration.actions
+    .flatMap((action) => action.forms.filter((form) => form.active))
+    .flatMap((form) => form.pages.flatMap((page) => page.fields))
+}

packages/events/src/router/events.get.test.ts

@@ -31,7 +31,7 @@ test('Returns multiple events', async () => {
   expect(events).toHaveLength(10)
 })
 
-test('Returns aggregated event with updated status and values', async () => {
+test.only('Returns aggregated event with updated status and values', async () => {
   const initialData = { name: 'John Doe', favouriteFruit: 'Banana' }
   const event = await client.event.create(generator.event.create())
   await client.event.actions.declare(

packages/events/src/router/router.ts

@@ -31,7 +31,10 @@ import {
   setLocations
 } from '@events/service/locations/locations'
 import { Context, middleware } from './middleware/middleware'
-import { getIndexedEvents } from '@events/service/indexing/indexing'
+import {
+  ensureIndexExists,
+  getIndexedEvents
+} from '@events/service/indexing/indexing'
 import { EventConfig, getUUID } from '@opencrvs/commons'
 import {
   DeclareActionInput,
@@ -79,14 +82,24 @@ export const appRouter = router({
   }),
   event: router({
     create: publicProcedure.input(EventInput).mutation(async (options) => {
-      const config = await getEventConfigurations(options.ctx.token)
-      const eventIds = config.map((c) => c.id)
+      const configurations = await getEventConfigurations(options.ctx.token)
+      const eventIds = configurations.map((c) => c.id)
 
       validateEventType({
         eventTypes: eventIds,
         eventInputType: options.input.type
       })
 
+      const configuration = configurations.find(
+        (c) => c.id === options.input.type
+      )
+
+      if (!configuration) {
+        throw new Error(`Event configuration not found ${options.input.type}`)
+      }
+
+      await ensureIndexExists(options.input.type, configuration)
+
       return createEvent({
         eventInput: options.input,
         createdBy: options.ctx.user.id,