feat: Add constants.humanName to allow countries to have custom full name format #7957
+195
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
from
1a13fc2 to
b66f929
Compare
Siyasanga
added
the
🚀 Ready to deploy
github-actions
bot
temporarily deployed
to
ocrvs-6830-human-name-constant
|
Your environment is deployed to https://ocrvs-6830-human-name-constant.opencrvs.dev |
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
from
b66f929 to
948771b
Compare
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
6 tasks
Zangetsu101
requested changes
Nov 22, 2024
There was a problem hiding this comment.
@Siyasanga After taking a look at the changes made to the e2e tests, I would say it's better to change all those places in core to use the new format instead. As if only some of the places use the new format, then it would just create confusion
Zangetsu101
added
🔧Waiting for fixes
and removed
🚀 Ready to deploy
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
from
a2148db to
c6f8c7a
Compare
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
3 times, most recently
from
3375112 to
40966ab
Compare
To allow countries to have custom ordering for full names #6830
To ensure that we get the format from the country-config #6830
To make the name more usable we had to extract the name formatting logic into it's own function. #6830
Replace older logic to get the name which was based on an assumption that we support names in multiple languages #6830
We've found cleaner way to make the rendered name customizable for each country through client copy from country-config #6830
We need to update all the places where a citizen's name is being referenced to show it in the format that the country chooses #6830
The expected name should match the format for the given country. #6830
Siyasanga
force-pushed
the
ocrvs-6830-human-name-constant
branch
from
40966ab to
fc69672
Compare
Siyasanga
added
🚀 Ready to deploy
github-actions
bot
temporarily deployed
to
ocrvs-6830-human-name-constant
|
Hi @Zangetsu101, hope you're good. Please review this PR when you have a chance. I have reverted the changes that were trying to generate the I've also removed the changes on the integration tests for the |
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
Siyasanga
temporarily deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Inactive
Siyasanga
deployed
to
ocrvs-6830-human-name-constant
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow countries to define their own full name format, we are adding a constants.humanName into the client.csv translations, which will then be used everywhere where we are displaying system users and citizen's name in the systems.
Addresses #6830