Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with formatting national phone numbers for countries with a '0' national prefix #8318

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Jan 10, 2025

@tareq89 tareq89 added this to the w IET Candidates milestone Jan 10, 2025
@tareq89 tareq89 requested a review from euanmillar January 10, 2025 10:57
@tareq89 tareq89 self-assigned this Jan 10, 2025

This comment has been minimized.

@euanmillar euanmillar modified the milestones: w IET Candidates, v1.6.3 Jan 10, 2025
@euanmillar euanmillar requested a review from rikukissa January 10, 2025 11:00
@euanmillar
Copy link
Collaborator

@tareq89 tareq89 added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Jan 10, 2025
@rikukissa
Copy link
Member

@tareq89 add a unit test please to verify formatting of works okay with different countries' phone number schemes

CHANGELOG.md Outdated Show resolved Hide resolved
@tareq89 tareq89 enabled auto-merge (squash) January 16, 2025 09:10
@tareq89 tareq89 removed the request for review from euanmillar January 16, 2025 09:10
@tareq89 tareq89 deployed to ocrvs-7635 January 16, 2025 09:11 — with GitHub Actions Active
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7635.opencrvs.dev

@tareq89 tareq89 merged commit 4f43c9b into develop Jan 16, 2025
71 of 72 checks passed
Copy link

sentry-io bot commented Jan 16, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Invalid country calling code convertToLocal(src/forms/register/mappings/quer... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 🔧Waiting for fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants