feat: Update system user form fields (#289)

* Remove NID field from the user details form

Remove the question that asks the user for a national ID number in the User details form as it is not required

opencrvs/opencrvs-core#6830

* Add back the NID field translations

The tranlation also get used views/form.ts file which is a different form config file

opencrvs/opencrvs-core#6830

* Record changes for this PR in the CHANGELOG

opencrvs/opencrvs-core#6830

* Rename firstNameEN to userFirstName in client.csv

Since the object was to remove the EN suffix, doing that for this key
would conflict with the already existing 'form.field.label.firstName' so
to differentiate, I opted to use 'form.field.label.userFirstName' to
associate it with the user form

opencrvs/opencrvs-core#6830

---------

Co-authored-by: Siyasanga Mtshokotsha <[email protected]>
Co-authored-by: Siyasanga Mtshokotsha <[email protected]>

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 1.7.0 Release candidate
 
+### New features
+
+- Update the translations for System user add/edit form, `Last name` to `User's surname` and `First name` to `User's first name` to make them less confusing for system users [#6830](https://github.com/opencrvs/opencrvs-core/issues/6830)
+
 ### Bug fixes
 
 - Protect individual certificate endpoint with token

src/translations/client.csv

@@ -963,7 +963,6 @@ form.field.label.fetchRegistrationModalInfo,,Birth Registration Number,Numéro d
 form.field.label.fileSizeError,,File size must be less than 2MB,La taille du fichier doit être inférieure à 2 Mo
 form.field.label.fileUploadError,,{type} supported image only,{type} format d'images accepté
 form.field.label.firstName,,First name(s),Prénom(s)
-form.field.label.firstNameEN,,First name(s),Prénom(s)
 form.field.label.firstNames,,First name(s),Prénom(s)
 form.field.label.healthInstitution,,Health Institution,Institution de santé
 form.field.label.hospital,,Hospital,Hôpital
@@ -1161,9 +1160,11 @@ form.field.label.uploadFile,,Upload,Télécharger
 form.field.label.urban,,Urban,Urbain
 form.field.label.userAttachmentSection,,Signature,Signature
 form.field.label.userDevice,,Device,Dispositif
+form.field.label.userFirstName,,User's first name,Prénom de l'utilisateur
 form.field.label.userSignatureAttachment,,User's signature,Signature de l'utilisateur
 form.field.label.userSignatureAttachmentDesc,,Ask the user to sign a piece of paper and then scan or take a photo,"Demandez à l'utilisateur de signer une feuille de papier, puis scannez ou prenez une photo."
 form.field.label.userSignatureAttachmentTitle,,Upload signature,Joindre la signature
+form.field.label.userSurname,,User's surname,Nom de famille de l'utilisateur
 form.field.label.verbalAutopsy,,Verbal autopsy,Autopsie verbale
 form.field.label.verbalAutopsyReport,,Verbal autopsy report,Rapport d'autopsie verbal
 form.field.label.weightAtBirth,,Weight at birth,Poids à la naissance