Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat implement birth v2 #353

Merged
merged 35 commits into from
Jan 16, 2025
Merged

Feat implement birth v2 #353

merged 35 commits into from
Jan 16, 2025

Conversation

jamil314
Copy link
Collaborator

@jamil314 jamil314 commented Jan 1, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

jamil314 added 22 commits January 2, 2025 15:07
@jamil314
fix: use number for weight at birth
d11abb6
@jamil314
feat: person input wip
fc6587d
@jamil314
Merge branch 'develop' into feat-birth-v2
78ba94b
@jamil314
feat: show dob or age based on dobUnknown checkbox
6015741
@jamil314
chore: rename directory
505a08e
@jamil314
amend: import from renamed directory
373323b
@jamil314
feat: add informant relation to birth form
07be5e2
@jamil314
Merge branch 'develop' into feat-birth-v2
4acd8f7
@jamil314
feat: render informant fields based on relation to child
c05f0d9
@jamil314
feat: separate the logic for concatenating field id
15fe150
@jamil314
feat: complete informant details apart form person inputs
2a3758a
@jamil314
feat: implement id and address
29b280a
@jamil314
refactor: create utils
ed40dd7
@jamil314
fix: handle undefined values in conditionals
2b184f9
@jamil314
chore: Merge branch "develop" into feat-birth-v2
64a65aa
@jamil314
feat: implement father and mother details
cd43a65
@jamil314
feat: implement upload supporting document
a177f5e
@jamil314
fix: use simpler concat
9e8e724
@jamil314
feat: use country field
e360b7b
@jamil314
feat: add place of birth
d9fbb68
@jamil314
fix: typo
fd1019a
@jamil314
fix: align label and required properties with legecy birth
a0a48ba
@jamil314 jamil314 mentioned this pull request Jan 9, 2025
Merged
@jamil314 jamil314 mentioned this pull request Jan 15, 2025
Open
makelicious
makelicious reviewed Jan 15, 2025
View reviewed changes
src/form/V2/birth.ts Outdated Show resolved Hide resolved
src/form/V2/birth.ts Outdated Show resolved Hide resolved
src/form/V2/birth.ts Outdated Show resolved Hide resolved
src/form/V2/birth.ts Outdated Show resolved Hide resolved
src/form/V2/birth.ts Outdated Show resolved Hide resolved
src/form/V2/messageDescriptors.ts Outdated Show resolved Hide resolved
src/form/V2/messageDescriptors.ts Outdated Show resolved Hide resolved
src/form/V2/person.ts Outdated
]

export const getAddressFields = (person: string): FieldConfig[] => {
// @Todo: Same as mother or deseased
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for us?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For us to complete in address input pr

src/form/V2/utils.ts Outdated Show resolved Hide resolved
src/form/V2/birth.ts Outdated Show resolved Hide resolved
makelicious
makelicious approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@jamil314 jamil314 merged commit bca5582 into develop Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makelicious makelicious makelicious approved these changes

@rikukissa rikukissa Awaiting requested review from rikukissa

Assignees
No one assigned
Labels
💅 Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamil314 @makelicious