Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events v2 collect certificate workflow boilerplate code #360

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Events v2 collect certificate workflow boilerplate code #360

wants to merge 2 commits into from

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Jan 10, 2025

@tareq89 tareq89 requested review from rikukissa and jamil314 January 10, 2025 14:33
@tareq89 tareq89 self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

jamil314
jamil314 reviewed Jan 13, 2025
View reviewed changes
src/form/tennis-club-membership.ts
@@ -341,6 +397,22 @@ export const tennisClubMembershipEvent = defineConfig({
),
forms: [TENNIS_CLUB_FORM]
},
{
type: 'COLLECT_CERTIFICATE',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.figma.com/design/TyOp4aUHJmiPz9IpBX5q4m/OpenCRVS-Design-Specifications-v3?node-id=18-1396&t=g2Jmw3yjWiWEQOTD-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamil314 jamil314 jamil314 left review comments

@rikukissa rikukissa Awaiting requested review from rikukissa

Assignees

@tareq89 tareq89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tareq89 @jamil314