Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postfix and removes inputFieldWidth #1012

Closed
wants to merge 1 commit into from
Closed

Conversation

jpye-finch
Copy link
Collaborator

updates weight postfix

image

Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. We just need to remember when merging this that a PR needs to be created in countryconfig with the type change (and potentially the form changes)

certificateHandlebars.weightAtBirth
),
inputFieldWidth: '78px'
postfix: 'kilograms (kg)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to translate this via formMessageDescriptors ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we only support strings for this prop, adding intl message support could be a good addition

@Zangetsu101
Copy link
Collaborator

Closing in favor of opencrvs#201

@Zangetsu101 Zangetsu101 closed this Jul 9, 2024
@Zangetsu101 Zangetsu101 deleted the weight-postfix branch July 9, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants