Various local testing improvements #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Set the correct helm variable Default openebs namespace Ensure make clean works Signed-off-by: Tiago Castro <[email protected]>
Add cleanup to the ci test.sh Git Ignore coverage results Fixup pulled go packages version Allow running tests without sudo. Tests is invoking the actual zfs pkg code, which does not use sudo. For now I've duplicated the code though we probably need to refactor this. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
Abhinandan-Purkait
approved these changes
Jan 8, 2025
sinhaashish
approved these changes
Jan 8, 2025
Signed-off-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?:
Add cleanup to the ci test.sh
Git Ignore coverage results
Fixup pulled go packages version
Allow running tests without sudo. Tests is invoking the actual zfs
pkg code, which does not use sudo. For now I've duplicated the code
though we probably need to refactor this.
set correct pullPolicy and default namespace
Set the correct helm variable
Default openebs namespace
Ensure make clean works
ci(gha): add missing go env vars
enhance local shell environment
run shellcheck on ci script
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>