This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
chore: Merging in Theseus Work to Master #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dialog UI Created - Tests as well
* feat: THES-105: Payment State Polling Payment State polling on Submit Payment and Get Active Order, with a normally non-closeable Dialog. * fix: Advisories permitted for the moment This spawned REV-3598. * fix: Removal of `PAYMENT_STATE.PROCESSING`, this state is internal to the Titan backend. * fix: Changes from PR Review
* feat: Payment State Polling Error Handling Per THES-216: - Adding 5 failures for HTTP issues, then we show a banner - Fatal Errors fail and show banner immediately Also: - Documentation Updates - Constants for Error Handling - Ability to generate an API Error without automatically throwing * chore: Updating Payment State Polling to use a Custom Routine * chore: Payment State Polling Reducer Tests * chore: Polling Reducer and Action Testing
* fix: swapping out `getQueryParameters` with `searchParams`
- `getQueryParameters` has been deprecated, so the code has been modified to use `URL(...).searchParams`.
- Moving Waffle Flag handling to an external file.
- 100% Coverage for Waffle Flag processing as well as interception.
Also allowlisted a vulnerability.
> Note: Used API 2 for Jest in its Tabular format. Nice for simpler values. and less eslint/visual formatting issues.
* fix: Merge `COMMERCE_COORDINATOR_BASE_URL` in Config from Env
- Includes moving service code so CC calls are at the end of the file.
* chore: Fixing some excluded code coverage files
- Permitting `src/data` to be covered
- excluding the specific files without coverage.
- Added a simple rootSagas Test
* fix: Moving `isWaffleFlagEnabled` with its sibling functions
- Also, testing.
* feat: Accepting Waffle Flags from the Environment
- A simple hijack of URL parsing to allow flags from the environment. This should ease development.
* feat: Adding `isCommerceCoordinatorEnabled`
Checks Waffle Flags to see if were in CC mode.
Additional testing and test refactoring.
* chore: Doc updates and moving Waffle Flags from magic strings to an Enum
* chore: Set CC Waffle Flag to use the MS1 Switch for Backend Selection
* feat: Swapping between Ecomm IDA and Coordinator based on Flags
- Testing updates including returning promises from the `perform` functions so that async work doesn't time out Jest
- Documentation Updates
- Setting payment processing dialog to never show unless we are in CC Mode
* fix: Remove CyberSource call from Coordinator Service
* chore: PR Updates, Testing and Removal of `GetActiveOrder`.
- The Service layer of the payment module now shares common data flow.
- GetActiveOrder (THES-234) removed as it has the same flow as getBasket.
- Tests reworked to cover both data flows.
* fix: Update .env.development-stage to target devstack
- Target DevStack CC unless overridden by `.env.private`
Co-authored-by: Phillip Shiu <[email protected]>
---------
Co-authored-by: Phillip Shiu <[email protected]>
…#789) * docs: Updates to Feature Toggle documentation for Environmental Flags - Updates to Feature Toggle documentation for Environmental Flags - Updating code pointers to show how the code was broken out This is part of THES-242. Co-authored-by: Phillip Shiu <[email protected]> --------- Co-authored-by: Phillip Shiu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.