Skip to content

Commit

Permalink
perf: normalize LMS vs. Studio debug-toolbar settings
Browse files Browse the repository at this point in the history
This change disables the profiling panel for performance reasons. It's
rarely useful anyway, given the lack of granularity in the data it
displays.

This commit also enables the Cache panel, which is import for tracking
where we're making excessive calls to redis/memcached.
  • Loading branch information
ormsbee committed Jan 18, 2025
1 parent 4035aa3 commit 48b7545
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
8 changes: 6 additions & 2 deletions cms/envs/devstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,13 @@
'debug_toolbar.panels.request.RequestPanel',
'debug_toolbar.panels.sql.SQLPanel',
'debug_toolbar.panels.signals.SignalsPanel',
'debug_toolbar.panels.profiling.ProfilingPanel',
'debug_toolbar.panels.cache.CachePanel',
'debug_toolbar.panels.history.HistoryPanel',
)

# ProfilingPanel has been intentionally removed for default devstack.py
# runtimes for performance reasons.
# 'debug_toolbar.panels.profiling.ProfilingPanel',
)

DEBUG_TOOLBAR_CONFIG = {
# Profile panel is incompatible with wrapped views
Expand Down
7 changes: 4 additions & 3 deletions lms/envs/devstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,12 @@
'debug_toolbar.panels.request.RequestPanel',
'debug_toolbar.panels.sql.SQLPanel',
'debug_toolbar.panels.signals.SignalsPanel',
'debug_toolbar.panels.cache.CachePanel',
'debug_toolbar.panels.history.HistoryPanel',

# ProfilingPanel has been intentionally removed for default devstack.py
# runtimes for performance reasons. If you wish to re-enable it in your
# local development environment, please create a new settings file
# that imports and extends devstack.py.
# runtimes for performance reasons.
# 'debug_toolbar.panels.profiling.ProfilingPanel',
)

DEBUG_TOOLBAR_CONFIG = {
Expand Down

0 comments on commit 48b7545

Please sign in to comment.