feat: adding course review metrics to content metadata and algolia index #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sheehan-edx
requested review from
johnnagro,
adamstankiewicz and
katrinan029
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8126-course-reviews
branch
2 times, most recently
from
12106bf to
2450c9e
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8126-course-reviews
branch
8 times, most recently
from
7fbd4a3 to
3633ef5
Compare
kiram15
approved these changes
Jan 4, 2024
johnnagro
suggested changes
Jan 4, 2024
| with self.assertRaises(requests.exceptions.RequestException): | ||
| client._retrieve_course_reviews(request_params) | ||
|
|
||
| assert 'Retrieving course reviews from course-discovery for page 1...' in mock_logger.info.call_args.args[0] |
There was a problem hiding this comment.
asserting log lines is less preferable than asserting the mocks are called with a specific input or some outcome/side-effect is observed
There was a problem hiding this comment.
Removed for a mock called assertion
| @@ -80,6 +81,75 @@ def _retrieve_metadata_for_content_filter(self, content_filter, page, request_pa | |||
| break | |||
| return response.json() | |||
|
|
|||
| def _retrieve_course_reviews(self, request_params): | |||
| """ | |||
| Makes a request to discovery's /api/v1/course_review/ paginated endpoint | |||
There was a problem hiding this comment.
is this endpoint paginated?
There was a problem hiding this comment.
locally testing it seems so?
| if run.get('uuid') == course_run_uuid: | ||
| run.update({'start': start_date, 'end': end_date}) | ||
|
|
||
| # Perform more steps to normalize and move keys around for more consistency across content types. | ||
| _normalize_course_metadata(metadata_record) | ||
|
|
||
| if review := reviews_for_courses_dict.get(content_key): |
There was a problem hiding this comment.
reviews_for_courses_dict is a list?
There was a problem hiding this comment.
nope- get_course_reviews should return a dictionary
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8126-course-reviews
branch
2 times, most recently
from
00643ed to
04457f3
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8126-course-reviews
branch
from
04457f3 to
21d6c12
Compare
johnnagro
approved these changes
Jan 5, 2024
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
…iews feat: adding course review metrics to content metadata and algolia index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
Link to the associated ticket
https://2u-internal.atlassian.net/browse/ENT-8126
Post-review