fix: disable filter by block on collections tab [FC-0076] #1576
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 92.96% 92.97%
=======================================
Files 1075 1075
Lines 21197 21205 +8
Branches 4560 4576 +16
=======================================
+ Hits 19706 19715 +9
+ Misses 1425 1418 -7
- Partials 66 72 +6 ☔ View full report in Codecov by Sentry. |
rpenido
changed the title
| useEffect(() => { | ||
| if (disabled) { | ||
| // Clear filters when disabled | ||
| const selectedBlockTypesFilter = blockTypesFilter; | ||
| const selectedProblemTypesFilter = problemTypesFilter; | ||
| setBlockTypesFilter([]); | ||
| setProblemTypesFilter([]); | ||
|
|
||
| return () => { | ||
| // Restore filters when re-enabled | ||
| setBlockTypesFilter(selectedBlockTypesFilter); | ||
| setProblemTypesFilter(selectedProblemTypesFilter); | ||
| }; | ||
| } | ||
| return () => {}; | ||
| }, [disabled]); |
There was a problem hiding this comment.
@rpenido This works perfectly! I see that patch coverage shows up as 100% but cannot find any tests that actually test this behaviour.
- I tested this: (Filtered components and verified collections tab behaviour)
- I read through the code
- I checked for accessibility issues
- Includes documentation
Co-authored-by: Navin Karkera <[email protected]>
ChrisChV
deleted the
rpenido/fal-3981-disable-filter-by-block-on-collections
branch
Re-implements the functionality added by openedx#1576 which was broken when storing types in search params. Had to use a different approach to avoid "insecure operation" errors from React. Also adds tests.
Description
This PR adds the
disabledprop forFilterByBlockTypecomponent and uses it on the Library Collection tab.More Information
Testing Instruction
FilterByBlockTypecomponentPrivate ref: FAL-3981