chore: update sidebar logic

openedx · Nov 17, 2023 · 025eec7 · 025eec7
1 parent c38d69f
commit 025eec7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/courseware/course/sidebar/SidebarContextProvider.jsx b/src/courseware/course/sidebar/SidebarContextProvider.jsx
@@ -27,8 +27,10 @@ const SidebarProvider = ({
   const [upgradeNotificationCurrentState, setUpgradeNotificationCurrentState] = useState(getLocalStorage(`upgradeNotificationCurrentState.${courseId}`));
 
   useEffect(() => {
-    // if the user has not purchased the course or previously opened the notification tray, show the notification tray
-    const showNotificationsOnLoad = !!verifiedMode || getSessionStorage(`notificationTrayStatus.${courseId}`) !== 'closed';
+    // if the user left the tray open in the previous session, open it again
+    // if the user is not verified, open the tray iff the previous session was open and the user on large screen
+    const openBySession = getSessionStorage(`notificationTrayStatus.${courseId}`) !== 'closed';
+    const showNotificationsOnLoad = openBySession || (!!verifiedMode && shouldDisplaySidebarOpen && openBySession );
     if (showNotificationsOnLoad) {
       setCurrentSidebar(SIDEBARS.NOTIFICATIONS.ID);
     }

diff --git a/src/data/sessionStorage.js b/src/data/sessionStorage.js
@@ -7,10 +7,7 @@
 function getSessionStorage(key) {
   try {
     if (global.sessionStorage) {
-      const rawItem = global.sessionStorage.getItem(key);
-      if (rawItem) {
-        return JSON.parse(rawItem);
-      }
+      return global.sessionStorage.getItem(key);
     }
   } catch (e) {
     // If this fails for some reason, just return null.