fix: remove courseId from event

openedx · Jun 3, 2024 · e839f1e · e839f1e
1 parent ada130a
commit e839f1e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 9 deletions.
diff --git a/src/courseware/course/sequence/Unit/ContentIFrame.jsx b/src/courseware/course/sequence/Unit/ContentIFrame.jsx
@@ -29,7 +29,6 @@ export const testIDs = StrictDict({
 
 const ContentIFrame = ({
   iframeUrl,
-  courseId,
   shouldShowContent,
   loadingMessage,
   id,
@@ -47,7 +46,6 @@ const ContentIFrame = ({
     id,
     iframeUrl,
     onLoaded,
-    courseId,
   });
 
   const {
@@ -126,7 +124,6 @@ ContentIFrame.propTypes = {
   elementId: PropTypes.string.isRequired,
   onLoaded: PropTypes.func,
   title: PropTypes.node.isRequired,
-  courseId: PropTypes.string.isRequired,
 };
 
 ContentIFrame.defaultProps = {

diff --git a/src/courseware/course/sequence/Unit/__snapshots__/index.test.jsx.snap b/src/courseware/course/sequence/Unit/__snapshots__/index.test.jsx.snap
@@ -49,7 +49,6 @@ exports[`Unit component output snapshot: not bookmarked, do not show content 1`]
     id="test-props-id"
   />
   <ContentIFrame
-    courseId="test-course-id"
     elementId="unit-iframe"
     id="test-props-id"
     loadingMessage="Loading learning sequence..."

diff --git a/src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.js b/src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.js
@@ -23,7 +23,6 @@ export const stateKeys = StrictDict({
 const useIFrameBehavior = ({
   elementId,
   id,
-  courseId,
   iframeUrl,
   onLoaded,
 }) => {
@@ -99,7 +98,6 @@ const useIFrameBehavior = ({
       sendTrackEvent('edx.bi.error.learning.iframe_load_failed', {
         iframeUrl,
         unitId: id,
-        courseId,
       });
       logError('Unit iframe failed to load. Server possibly returned 4xx or 5xx response.', {
         iframeUrl,

diff --git a/src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.test.js b/src/courseware/course/sequence/Unit/hooks/useIFrameBehavior.test.js
@@ -52,7 +52,6 @@ const props = {
   elementId: 'test-element-id',
   id: 'test-id',
   iframeUrl: 'test-iframe-url',
-  courseId: 'test-course-id',
   onLoaded: jest.fn(),
 };
 
@@ -280,7 +279,6 @@ describe('useIFrameBehavior hook', () => {
         hook.handleIFrameLoad();
         const eventName = 'edx.bi.error.learning.iframe_load_failed';
         const eventProperties = {
-          courseId: props.courseId,
           unitId: props.id,
           iframeUrl: props.iframeUrl,
         };

diff --git a/src/courseware/course/sequence/Unit/index.jsx b/src/courseware/course/sequence/Unit/index.jsx
@@ -54,7 +54,6 @@ const Unit = ({
       <UnitSuspense {...{ courseId, id }} />
       <ContentIFrame
         elementId="unit-iframe"
-        courseId={courseId}
         id={id}
         iframeUrl={iframeUrl}
         loadingMessage={formatMessage(messages.loadingSequence)}