Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AU-2073): Trigger track event when iframe fails on load #1407

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

Rodra
Copy link
Contributor

@Rodra Rodra commented Jun 3, 2024

No description provided.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (9437142) to head (e839f1e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         307      307           
  Lines        5267     5268    +1     
  Branches     1338     1338           
=======================================
+ Hits         4679     4680    +1     
  Misses        572      572           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sendTrackEvent('edx.bi.error.learning.iframe_load_failed', {
iframeUrl,
unitId: id,
courseId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, you don't need the courseId here since course ID is part of the unit ID:

xblock-v1:{course_id}{block_id}

@Rodra Rodra merged commit 072d608 into master Jun 4, 2024
7 checks passed
@Rodra Rodra deleted the feat/AU-2073 branch June 4, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants