-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: masquerade dropdown not showing current selection #1434
fix: masquerade dropdown not showing current selection #1434
Conversation
Thanks for the pull request, @kaustavb12! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
57c5ce4
to
d72eb23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
- I tested this on a sandbox.
- I read through the code.
- I checked for accessibility issues.
@openedx/committers-frontend-app-learning Are you able to kick off a build for these changes or will we need to ask Axim to grant you the necessary permissions? |
@itsjeyd Just started the build :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 87.78% 88.48% +0.69%
==========================================
Files 310 310
Lines 5320 5322 +2
Branches 1350 1350
==========================================
+ Hits 4670 4709 +39
+ Misses 633 596 -37
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Thanks @farhaanbukhsh. Looks like it worked only partially -- I'm still seeing "7 successful and 1 expected checks" above. What needs to happen for the remaining checks to run? |
@kaustavb12 Please rebase the PR - somehow one of the CI checks got "stuck". |
59d9db5
to
86be66d
Compare
PR rebased. All checks passed. |
Description
This PR fixes the issue where selecting "Specific Student..." masquerade option from the dropdown would not change the selected option in the dropdown.
Steps to recreate issue:
Before:
After:
Testing instructions
Setup this PR branch in local or in a sandbox as usual.
Other information
Private Ref : OpenCraft Internal Ticket BB-9074