Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: masquerade dropdown not showing current selection #1434

Conversation

kaustavb12
Copy link
Contributor

@kaustavb12 kaustavb12 commented Aug 13, 2024

Description

This PR fixes the issue where selecting "Specific Student..." masquerade option from the dropdown would not change the selected option in the dropdown.

Steps to recreate issue:

  1. Open course outline page for any course as a staff user.
  2. Ensure the masquerade option is currently set to "Staff".
  3. Select "Specifc Student.." option from the masquerade dropdown
  4. Open the drop down again and notice that "Specifc Student.." is NOT highlighted as selected.

Before:
masquerade_selection_fix_before

After:
masquerade_selection_fix_after

Testing instructions

Setup this PR branch in local or in a sandbox as usual.

  1. Open course outline page for any course as a staff user.
  2. Ensure the masquerade option is currently set to "Staff".
  3. Select "Specifc Student.." option from the masquerade dropdown
  4. Open the drop down again and that "Specifc Student.." is highlighted as selected.

Other information

Private Ref : OpenCraft Internal Ticket BB-9074

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @kaustavb12!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

@viadanna viadanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

  • I tested this on a sandbox.
  • I read through the code.
  • I checked for accessibility issues.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 7, 2024
@itsjeyd
Copy link

itsjeyd commented Sep 7, 2024

@openedx/committers-frontend-app-learning Are you able to kick off a build for these changes or will we need to ask Axim to grant you the necessary permissions?

@farhaanbukhsh
Copy link
Member

@itsjeyd Just started the build :)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.48%. Comparing base (b9d1198) to head (86be66d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tor-toolbar/masquerade-widget/MasqueradeWidget.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   87.78%   88.48%   +0.69%     
==========================================
  Files         310      310              
  Lines        5320     5322       +2     
  Branches     1350     1350              
==========================================
+ Hits         4670     4709      +39     
+ Misses        633      596      -37     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 17, 2024
@itsjeyd
Copy link

itsjeyd commented Sep 20, 2024

Thanks @farhaanbukhsh. Looks like it worked only partially -- I'm still seeing "7 successful and 1 expected checks" above. What needs to happen for the remaining checks to run?

CC @bradenmacdonald @mphilbrick211

@bradenmacdonald
Copy link
Contributor

@kaustavb12 Please rebase the PR - somehow one of the CI checks got "stuck".

@kaustavb12 kaustavb12 force-pushed the kaustav/fix_masquerade_dropdown_selection branch from 59d9db5 to 86be66d Compare September 23, 2024 06:01
@kaustavb12
Copy link
Contributor Author

PR rebased. All checks passed.

@itsjeyd @bradenmacdonald

@bradenmacdonald bradenmacdonald merged commit 1d19ae0 into openedx:master Sep 23, 2024
8 checks passed
@bradenmacdonald bradenmacdonald deleted the kaustav/fix_masquerade_dropdown_selection branch September 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants