Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add build-scss-to-css-map to package.json #2085

Conversation

brian-smith-tcril
Copy link
Contributor

Description

In https://github.com/openedx/paragon/tree/alpha#usage, one of the steps is running

npm run build-scss-to-css-map # creats scss-to-css-core.json and scss-to-css-components.json 

this was giving me a

npm ERR! Missing script: "build-scss-to-css-map"

error.

It seems it was removed in 9184d80, if this was intentional, I will close this PR and make one updating the README instead.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@adamstankiewicz
Copy link
Member

@brian-smith-tcril I believe removing this command was intentional. For example, in this open PR, that command is no longer mentioned in the README usage.

(Note, this PR appears way larger than it actually is (it's only a change to the README file!) presumably because of all the issues with ending up needing to essentially rewrite the git history on the alpha branch via git reset --hard <sha>...)

@brian-smith-tcril
Copy link
Contributor Author

@adamstankiewicz sounds good! I'll close this and let the conversation continue in #2086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design tokens README usage instructions lead to "Missing script" errors
2 participants