Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to embed superset dashboard in instructor dashboard #2

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 29, 2024

See openedx/openedx-aspects#192 for more information

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 29, 2024
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

@bmtcril bmtcril merged commit bf1a2c0 into main Mar 1, 2024
8 of 9 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bmtcril bmtcril deleted the cag/embed-superset branch March 1, 2024 13:57
@bmtcril
Copy link
Contributor

bmtcril commented Mar 5, 2024

@felipemontoya I know that you approved this code for inclusion in Open edX under the EduNEXT CLA elsewhere, but I forgot to ping you here, where people are more likely to look. Can you confirm that here as well?

@felipemontoya
Copy link
Member

For sure, I commented that in openedx/openedx-aspects#193

As I said there, as the legal representative of edunext and the signer of the CLA I approve the change of license and the inclusion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants