Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create aspects-consumer deployment #610

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 20, 2024

Description

This PR adds a deployment for an aspects-consumer which consumes events from the event bus. It also updates the settings of caliper and xapi to use the event bus backends.

Two settings are setup to control when to enable the event bus consumer and producer:

  • ASPECTS_ENABLE_EVENT_BUS_CONSUMER
  • ASPECTS_ENABLE_EVENT_BUS_PRODUCER

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 20, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch 2 times, most recently from 3c710fb to 730e377 Compare February 21, 2024 19:20
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 22, 2024
@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch from 730e377 to 29b3f1a Compare February 23, 2024 19:41
@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch from 29b3f1a to 1b0a305 Compare March 19, 2024 21:36
@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch 6 times, most recently from 2bb6097 to a1675dc Compare March 22, 2024 20:48
@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch from a1675dc to c2699a3 Compare April 1, 2024 18:51
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the settings upgrades from in-flight ERB are in I'm happy to thumb this.

@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch 7 times, most recently from ce04e0e to 0fc24b6 Compare April 2, 2024 20:20
@Ian2012 Ian2012 force-pushed the cag/event-bus-consumer branch from 0fc24b6 to 9a42807 Compare April 2, 2024 20:45
@Ian2012 Ian2012 merged commit ab29ff9 into main Apr 3, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/event-bus-consumer branch April 3, 2024 17:38
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants