-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to superset v4.1.1 #939
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Ian2012! This repository is currently maintained by @bmtcril. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to update the geckodriver & firefox versions. They changed from 4.0.2
ARG GECKODRIVER_VERSION=v0.34.0
ARG FIREFOX_VERSION=125.0.3
I think it now comes pre-bundled in the image but I need to verify it |
5cc2c9b
to
30146a0
Compare
56235f3
to
68e661c
Compare
@@ -216,6 +216,8 @@ spec: | |||
name: docker | |||
- mountPath: /app/pythonpath | |||
name: pythonpath | |||
- mountPath: /app/pythonpath/openedx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, why were these moves necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They upgraded the python version and that causes issues with imports without a module
68e661c
to
06f35d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE the asset tagging
tutoraspects/templates/aspects/build/aspects-superset/Dockerfile
Outdated
Show resolved
Hide resolved
ea90a73
to
21ed833
Compare
78ba6da
to
79d8935
Compare
Hey @Ian2012, just checking in to see if you're still planning to continue working on this PR? |
Yes, waiting on the official release before proceeding, |
@Ian2012 OK I see, thanks for the update! |
5925ef4
to
fcea1b5
Compare
There's an issue on Superset right now about the images not being available yet: apache/superset#30919 |
15ea54a
to
a9bb4bc
Compare
chore: install mysql from requirements fix: install mysql from requirements
fix: deduplicate mount volume name
a9bb4bc
to
86790f7
Compare
86790f7
to
3791615
Compare
@bmtcril The decision was to leave this out for sumac, right? |
Correct, we won't have time to fully test everything before Sumac release. We're still waiting on Sara's latest changes to release the next version for Sumac, so probably tomorrow. I'll close and reopen this to kick the CLA check, it's been hanging a lot. |
@itsjeyd yes, thanks! We'll be adding it as part of the breaking changes work 👍 |
Description
This PR upgrades superset to v4.1.1
Now, we manually install MySQL client, see apache/superset#29727 for more information.
This PR also enables tagging and sets default tags to original and translated assets: