Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update client interface with store and model getter/setter #155

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ewanharris
Copy link
Member

Description

Adds the getter/setter methods for Authorization Model ID and Store ID onto the SdkClient interface so that when generating a mock from this client they can be used.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.98%. Comparing base (3768fc2) to head (929fc88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files         102      102           
  Lines       12405    12405           
=======================================
  Hits         3223     3223           
  Misses       8911     8911           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris marked this pull request as ready for review January 7, 2025 17:19
@ewanharris ewanharris requested a review from a team as a code owner January 7, 2025 17:19
@ewanharris ewanharris added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 2adebcc Jan 7, 2025
9 checks passed
@ewanharris ewanharris deleted the fix/add-setstoreid-to-client-interface branch January 7, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants