Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

met à jour Openfisca-France en version 155.0.0 #188

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

baptou12
Copy link
Contributor

No description provided.

@baptou12 baptou12 force-pushed the maj-version-openfisca-france branch from 6c2ef10 to 2a7eacd Compare November 15, 2023 09:43
Copy link
Contributor

@Allan-CodeWorks Allan-CodeWorks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS niveau fonctionalité mais remarque sur le changelog

CHANGELOG.md Outdated

_Pour les changements détaillés et les discussions associées, référencez la pull request [#188](https://github.com/openfisca/openfisca-france-local/pull/188)

### Changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En montant la version d'openfisca-france on intègre des fonctionnalités nouvelles donc on on fait une mise à jour mineur
Il me semble donc plus cohérent d'utiliser la section added dans le changelog et de formuler avec le mot ajout, exemple :

  • Ajoute la compatibilité avec les versions 156 d' OpenFisca-France

Pas bloquant pour le merge, juste mon avis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ça marche

@baptou12 baptou12 force-pushed the maj-version-openfisca-france branch from 2a7eacd to 8cbb4b7 Compare November 15, 2023 15:21
@baptou12 baptou12 merged commit d93b34d into master Nov 15, 2023
9 checks passed
@baptou12 baptou12 deleted the maj-version-openfisca-france branch November 15, 2023 15:29
@guillett guillett added this to the Passé milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants