Search #58
Open
Search #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy paste issues (Haystack -> Metrics) - Casing issues ([Kk]inetic) - Deprecated dependency (angular2-infinite-scroll) - Slightly wrong filename (timeline.component.*s*css)
Note: it's not clear to the user that you're only searching #tags here. Also: this endpoint is case sensitive, while /ideaflow/tasks?tag=abc is not.
How it works:
- Search on enter
- Show all results (or, if on the task page, the current task) when the
search is cleared or only whitespace is entered
- Shows an error if there is one, example:
Error while searching: Response with status: 500 Internal Error for URL: http://localhost:8080/storyweb/faq?tag=userQueryHere
Please try again.
- Shows 'no results for ___' if nothing was found. Also shows the main
list/all results/the current task in this case (as if the search had
been cleared)
Caveats:
- Lots of code duplication
- There's no debouncing. If a user holds enter it /will/ hammer the
backend server (though the backend should have rate-limiting
eventually anyway, the ui also shouldn't be malicious in this way)
- Exposes inconsistent backend behavior. The search endpoints have some
quirks:
- /storyweb/glossary?tag[]=...
- only searches term names
- only searches term names prefixed with # (the user must not
specify the '#'
- (good) case insensitive
- (good) will search partial words
- /storyweb/faq/?tag[]=...
- case sensitive
- will only search a whole term (e.g. 'tes' doesn't match 'test')
- (seems fine) only searches for #hashtags, I think only in
descriptions but I haven't verified that
- /ideaflow/task?tag[]=...
- (good) case insensitive
- (good) will search partial words
- (seems ok... but confusing) only searches #hashtags, but the user
won't see those unless they click into the task... so you have to
know what you're looking for (i.e. it cannot be used as a filter)
|
This is finally ready for review! See the commit message in d16b0e6 for commentary about how it works and some things that need to be opened as issues for the backend service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Some notes:
GH says it can't automatically merge... but I'm not sure why because after a fetch I can merge it into master just fineupstream/masterinstead of origin.