-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3367 Add support for person attributes #423
base: main
Are you sure you want to change the base?
Conversation
Size Change: -265 kB (-17.25%) 👏 Total Size: 1.27 MB
ℹ️ View Unchanged
|
be9d967
to
48be05c
Compare
7b25040
to
ebf119f
Compare
ebf119f
to
f95290b
Compare
So the immediate thing I see here is that we're embedding "format" in the form. I don't really love when we duplicate metadata like this in forms. Just load the format from the backend definition of the attribute type, so we don't face weird issues where changing an attribute type causes forms to break. |
8ac443b
to
e0f7bcc
Compare
e0f7bcc
to
e9aa02e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @CynthiaKamau! Any chance we can have some integrational test cases covering all supported rendering types?
src/components/inputs/ui-select-extended/ui-select-extended.component.tsx
Outdated
Show resolved
Hide resolved
e967865
to
cb6a495
Compare
a920aa0
to
6776aac
Compare
Requirements
Summary
Add support for person attributes
Schema :
Screenshots
Screen.Recording.2024-11-21.at.13.54.06.mov
Related Issue
Other