Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Use fewer Webpack chunks #162

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Nov 10, 2023

Requirements

Summary

This is part of a series of commits aimed at reducing the number of Webpack chunks and thus the number of files asynchronously loaded by the application. Home is, of course, a very small app, so the file reduction here is small, but since it's the main landing page, this should speed-up the initial rendering.

Screenshots

Related Issue

Other

@ibacher ibacher requested a review from denniskigen November 10, 2023 17:32
Copy link
Contributor

Size Change: +984 B (0%)

Total Size: 217 kB

ℹ️ View Unchanged
Filename Size Change
packages/esm-home-app/dist/130.js 173 kB +1.02 kB (+1%)
packages/esm-home-app/dist/242.js 0 B -211 B (removed) 🏆
packages/esm-home-app/dist/319.js 131 B -1 B (-1%)
packages/esm-home-app/dist/460.js 172 B -1 B (-1%)
packages/esm-home-app/dist/518.js 0 B -2.09 kB (removed) 🏆
packages/esm-home-app/dist/574.js 131 B -1 B (-1%)
packages/esm-home-app/dist/62.js 22.1 kB -3 B (0%)
packages/esm-home-app/dist/652.js 0 B -2.81 kB (removed) 🏆
packages/esm-home-app/dist/757.js 131 B -1 B (-1%)
packages/esm-home-app/dist/784.js 2.63 kB -3 B (0%)
packages/esm-home-app/dist/788.js 131 B -1 B (-1%)
packages/esm-home-app/dist/807.js 143 B -1 B (-1%)
packages/esm-home-app/dist/820.js 0 B -1.3 kB (removed) 🏆
packages/esm-home-app/dist/833.js 131 B -1 B (-1%)
packages/esm-home-app/dist/913.js 5.71 kB -1 B (0%)
packages/esm-home-app/dist/main.js 6.15 kB +2.49 kB (+68%) 🆘
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.14 kB -7 B (0%)
packages/esm-home-app/dist/656.js 3.89 kB +3.89 kB (new file) 🆕

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @ibacher.

@denniskigen denniskigen merged commit cef0d8a into main Nov 10, 2023
5 checks passed
@denniskigen denniskigen deleted the feat/fewer-webpack-chunks branch November 10, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants