Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Add GitHub Actions flows to automate Transifex and upgrade config #174

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jan 16, 2024

Requirements

Summary

This PR adds two GitHub Actions workflows aimed at automating (to an extent) our use of Transifex. Specifically:

  • tx-push: Run on every push to main, this pushes the translation files to Transifex to ensure the strings on Transifex are up-to-date.
  • tx-pull: This is a scheduled job run daily at 8:10 PM UTC, which is fairly arbitrary. It pulls changes from Transifex and, if any updates are made (🤞), it should create a PR to update those files. Subsequent updates before a PR is merged should update the PR in question.

Aside from the time difference on tx-pull, this is identical to openmrs/openmrs-esm-core#887

Screenshots

Related Issue

Other

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @ibacher! It looks like this obviates https://github.com/openmrs/openmrs-esm-home/pull/173/files in part.

Copy link
Contributor

Size Change: 0 B

Total Size: 217 kB

ℹ️ View Unchanged
Filename Size
packages/esm-home-app/dist/130.js 173 kB
packages/esm-home-app/dist/319.js 131 B
packages/esm-home-app/dist/460.js 172 B
packages/esm-home-app/dist/574.js 131 B
packages/esm-home-app/dist/62.js 22.1 kB
packages/esm-home-app/dist/656.js 3.88 kB
packages/esm-home-app/dist/757.js 131 B
packages/esm-home-app/dist/784.js 2.63 kB
packages/esm-home-app/dist/788.js 131 B
packages/esm-home-app/dist/807.js 143 B
packages/esm-home-app/dist/833.js 144 B
packages/esm-home-app/dist/913.js 5.71 kB
packages/esm-home-app/dist/main.js 6.14 kB
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.14 kB

compressed-size-action

@ibacher
Copy link
Member Author

ibacher commented Jan 16, 2024

Yes. I needed to update the tx/config or else this PR wouldn't pass. Should be reconcilable though.

@denniskigen
Copy link
Member

Cool. This LGTM. Feel free to merge

@ibacher ibacher merged commit 23a5769 into main Jan 16, 2024
5 checks passed
@ibacher ibacher deleted the chore/update-tx-add-workflows branch January 16, 2024 20:54
@ibacher
Copy link
Member Author

ibacher commented Jan 16, 2024

Just waiting for the patient-chart to publish because of the deploy job...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants