(fix): Wrap page header in t function #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -50 B (-0.01%) Total Size: 373 kB ℹ️ View Unchanged
|
|
Thanks, @NethmiRodrigo. I wouldn't expect to see changes to the non- |
|
@denniskigen yeah makes sense. I just added the same text that was there from |
|
yeah, best to see what we get back from Transifex so we know if there's anything that should be fixed upstream. |
|
Alrighty @denniskigen , done |
denniskigen
force-pushed
the
fix/page-header-translation
branch
from
72b31f4 to
aebf942
Compare
denniskigen
reviewed
Nov 21, 2024
Comment on lines
-33
to
-40
| // t('home', 'Home'); | ||
|
|
||
| registerBreadcrumbs([ | ||
| { | ||
| path: `${window.spaBase}/${pageName}`, | ||
| title: () => Promise.resolve(window.i18next.t('home', { defaultValue: 'Home', ns: moduleName })), | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
Removed because we're no longer using the breadcrumbs navigation pattern in the Home app.
Comment on lines
+13
to
+17
| /** | ||
| * Translation for the home page header | ||
| * // t('home', 'Home') | ||
| */ | ||
| return <PageHeader className={styles.pageHeader} illustration={<HomePictogram />} title={t(dashboardTitle)} />; |
There was a problem hiding this comment.
@NethmiRodrigo I think this is the correct pattern to follow for translating the dashboard title.
denniskigen
approved these changes
Nov 21, 2024
denniskigen
added a commit
that referenced
this pull request
Nov 28, 2024
This commit cuts a new patch release of the Home app, v5.5.1, with the following changes: * (fix) Wrap page header in t function by @NethmiRodrigo in #226 * (chore) Update translations from Transifex by @github-actions in #219 * (chore) Bump webpack from 5.93.0 to 5.94.0 by @dependabot in #220 * (chore) Bump express from 4.19.2 to 4.21.0 by @dependabot in #221 * (chore) Bump rollup from 2.77.2 to 2.79.2 by @dependabot in #223 * (chore) Update translations from Transifex by @github-actions in #224 * (chore) Bump http-proxy-middleware from 2.0.6 to 2.0.7 by @dependabot in #225 * (chore) Tweak tsconfig lib targets by @denniskigen in #227 * (chore) Remove unused test wrapper helper by @denniskigen in #228 * (chore) Update translations from Transifex by @github-actions in #229 * (docs) O3-3525: Enhance README by @Twiineenock in #211
NethmiRodrigo
pushed a commit
that referenced
this pull request
Dec 2, 2024
This commit cuts a new patch release of the Home app, v5.5.1, with the following changes: * (fix) Wrap page header in t function by @NethmiRodrigo in #226 * (chore) Update translations from Transifex by @github-actions in #219 * (chore) Bump webpack from 5.93.0 to 5.94.0 by @dependabot in #220 * (chore) Bump express from 4.19.2 to 4.21.0 by @dependabot in #221 * (chore) Bump rollup from 2.77.2 to 2.79.2 by @dependabot in #223 * (chore) Update translations from Transifex by @github-actions in #224 * (chore) Bump http-proxy-middleware from 2.0.6 to 2.0.7 by @dependabot in #225 * (chore) Tweak tsconfig lib targets by @denniskigen in #227 * (chore) Remove unused test wrapper helper by @denniskigen in #228 * (chore) Update translations from Transifex by @github-actions in #229 * (docs) O3-3525: Enhance README by @Twiineenock in #211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR wraps the page header title in the
tfunction so that it can be translated. I had to addHomewith the capitalHto the translation files, as the keyhomedoesn't get applied to the text.Screenshots
After fix:
Before fix:
Related issue
Other