(chore) Tweak tsconfig lib targets #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tweaks the base TypeScript config to allow for better module resolution and better support for modern JavaScript features. Specifically, it removes extraneous lib targets. `dom`, `dom.iterable`, and `esnext` are sufficient. `es2018`, `es2020`, `es2021`, and `es2022` are cumulative - each one includes all the previous ones. `esnext` includes all current and proposed ECMAScript features.
|
Size Change: 0 B Total Size: 373 kB ℹ️ View Unchanged
|
chibongho
reviewed
Nov 22, 2024
| }, | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "strictNullChecks": true, | ||
| "target": "esnext", | ||
| "target": "esnext" |
There was a problem hiding this comment.
Should we change the target to be more conservative (maybe es2022?), as older browsers do not support bleeding edge features?
There was a problem hiding this comment.
The ts-config is actually pretty irrelevant. We just use ts for type-checking. This is what the bundler uses for the actual output.
denniskigen
added a commit
that referenced
this pull request
Nov 28, 2024
This commit cuts a new patch release of the Home app, v5.5.1, with the following changes: * (fix) Wrap page header in t function by @NethmiRodrigo in #226 * (chore) Update translations from Transifex by @github-actions in #219 * (chore) Bump webpack from 5.93.0 to 5.94.0 by @dependabot in #220 * (chore) Bump express from 4.19.2 to 4.21.0 by @dependabot in #221 * (chore) Bump rollup from 2.77.2 to 2.79.2 by @dependabot in #223 * (chore) Update translations from Transifex by @github-actions in #224 * (chore) Bump http-proxy-middleware from 2.0.6 to 2.0.7 by @dependabot in #225 * (chore) Tweak tsconfig lib targets by @denniskigen in #227 * (chore) Remove unused test wrapper helper by @denniskigen in #228 * (chore) Update translations from Transifex by @github-actions in #229 * (docs) O3-3525: Enhance README by @Twiineenock in #211
NethmiRodrigo
pushed a commit
that referenced
this pull request
Dec 2, 2024
This commit cuts a new patch release of the Home app, v5.5.1, with the following changes: * (fix) Wrap page header in t function by @NethmiRodrigo in #226 * (chore) Update translations from Transifex by @github-actions in #219 * (chore) Bump webpack from 5.93.0 to 5.94.0 by @dependabot in #220 * (chore) Bump express from 4.19.2 to 4.21.0 by @dependabot in #221 * (chore) Bump rollup from 2.77.2 to 2.79.2 by @dependabot in #223 * (chore) Update translations from Transifex by @github-actions in #224 * (chore) Bump http-proxy-middleware from 2.0.6 to 2.0.7 by @dependabot in #225 * (chore) Tweak tsconfig lib targets by @denniskigen in #227 * (chore) Remove unused test wrapper helper by @denniskigen in #228 * (chore) Update translations from Transifex by @github-actions in #229 * (docs) O3-3525: Enhance README by @Twiineenock in #211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR tweaks the base TypeScript config to allow for better module resolution and better support for modern JavaScript features. Specifically, it removes extraneous lib targets.
[dom, dom.iterable, esnext]should be sufficient for our setup.es2018,es2020,es2021, andes2022are cumulative - each one includes all the previous ones.esnextincludes all current and proposed ECMAScript features.Resources
Screenshots
Related issue
Other