-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add remote-select question type and migrate data sources to o3 schema format #157
Conversation
e3c3676
to
81507c6
Compare
ec3b217
to
4987018
Compare
…te-select` Question
4987018
to
35d3372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Thanks, @donaldkibet! I've left some nitpicky suggestions around error handling and type annotations.
projects/ngx-formentry/src/components/ngx-remote-select/ngx-remote-select.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-formentry/src/components/ngx-remote-select/ngx-remote-select.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-formentry/src/components/ngx-remote-select/ngx-remote-select.component.ts
Show resolved
Hide resolved
projects/ngx-formentry/src/form-entry/form-factory/question.factory.ts
Outdated
Show resolved
Hide resolved
projects/ngx-formentry/src/form-entry/form-factory/question.factory.ts
Outdated
Show resolved
Hide resolved
projects/ngx-formentry/src/form-entry/form-factory/question.factory.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @donaldkibet LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requirements
Summary
Implements two changes:
dataSources
schema to align with o3 format while maintaining backwards compatibilitySample Schema
Screenshots
Related Issue
Other