feat: configure ssr handler to only match known routes #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orinokai
changed the title
📊 Package size report 0.05%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: catch-all route must be enabled before merging this as we want to soft-launch and collect data
Description
Previously, the SSR handler has been configured to catch all routes, which ensures it can back any route with server side rendering and means we don't have to handle the routing logic at the edge (we're currently unable to support full URLPattern matching in our redirect engine).
However, this approach also causes the SSR handler to be invoked for paths that are not valid routes. This is a problem when there are many requests to these paths, e.g. in the case of a bot or bad actor.
This PR parses out a superset of valid routes from the
routes-manifest.json(and an assortment of other manifest files) and configures the SSR handler to match on only these paths, ensuring API routes, base paths and i18n are all supported.Most of the important changes are in
src/build/functions/server.ts.Tests
New routing tests added and server-components fixture updated
Relevant links (GitHub issues, etc.) or a picture of cute animal
Closes FRB-1344, FRB-1478