New file utils.js, moved teardown function #1080
Conversation
AwesomeSauce42
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Co-authored-by: Matt Provost <[email protected]> Signed-off-by: Shashwat Prakash <[email protected]>
Co-authored-by: Matt Provost <[email protected]> Signed-off-by: Shashwat Prakash <[email protected]>
Signed-off-by: Shashwat Prakash <[email protected]>
Made the changes! |
|
@AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749 Also, please add an entry to the Changlelog file, under the "Infrastructure" section. |
There was a problem hiding this comment.
Good progress, just a few more small things. Also, like @joshuarrrr said, this should get a changelog entry :)
| if (changed) fs.writeFileSync(file, content, 'utf8'); | ||
| }); | ||
| } | ||
| /* End of Aliases */ |
There was a problem hiding this comment.
This marker should remain in the codebase
There was a problem hiding this comment.
This file should also get an empty line at the end of the file.
There was a problem hiding this comment.
alright will change this
Im not sure what to add under Infrastructure here, would a simple :
|
Signed-off-by: Awesomesauce42 <[email protected]>
|
@AwesomeSauce42 Which issue is this for? The issue number in the description doesn't appear to be valid. |
In the Changelog entries, we're aiming to capture the impact of the change, so generally more of the "why" than the "how" or "what". So potentially something like "Improve organization of build scripts by isolating utilities (#1080)". (It can go under the Refactor section) |
|
@AwesomeSauce42 Just checking in on the progress of this - have you had a chance to look at the feedback, or do you have other questions about the next steps? I'm marking it as a draft for now. |
Yes, I've made the changes on my local, but I'm having issues with my github pushes, I have been getting the error: Have been trying to fix this but getting stuck here. |
Signed-off-by: Awesomesauce42 <[email protected]>
Signed-off-by: Awesomesauce42 <[email protected]>
Signed-off-by: Awesomesauce42 <[email protected]>
|
Hi, I've made the changes that were required. Could you check this once? I'm still new to this so it took a little time, apologies for the same. |
| <<<<<<< HEAD | ||
|
|
||
| ======= | ||
| >>>>>>> cc445de2f11c9b8239d710133673ddc534d73b8f |
There was a problem hiding this comment.
Looks like there's a merge conflict remnant here
Description
Added a utils file and moved the euiBuildTimeAliasTearDown function to it.
Issues Resolved
Works on issue #1061
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.