[Fix] Updated new polygon icon svg #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Willie Hung <[email protected]>
willie-hung
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
willie-hung
changed the title
Signed-off-by: Willie Hung <[email protected]>
BSFishy
reviewed
Oct 13, 2023
Signed-off-by: Willie Hung <[email protected]>
|
@BSFishy I've added the blank line. Thanks! |
BSFishy
approved these changes
Oct 13, 2023
|
@BSFishy Just a little curious about the reason of adding a blank space. Is it for maintaining consistency with other SVG files? |
joshuarrrr
approved these changes
Oct 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Updated new polygon svg & updated related snapshots Signed-off-by: Willie Hung <[email protected]> * Add CHANGELOG Signed-off-by: Willie Hung <[email protected]> * Add blank line at the end of the polygon.svg file Signed-off-by: Willie Hung <[email protected]> --------- Signed-off-by: Willie Hung <[email protected]> (cherry picked from commit a90eadd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
|
@Willie-The-Lord The blank line at the end of every file is a more general convention - see https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file . For the purpose of this project, it's mostly about ensuring clean diffs via git. |
|
@joshuarrrr Thank you for sharing! |
joshuarrrr
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Updated new polygon svg & updated related snapshots Signed-off-by: Willie Hung <[email protected]> * Add CHANGELOG Signed-off-by: Willie Hung <[email protected]> * Add blank line at the end of the polygon.svg file Signed-off-by: Willie Hung <[email protected]> --------- Signed-off-by: Willie Hung <[email protected]> (cherry picked from commit a90eadd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated new polygon icon svg
Issues Resolved
Screenshot
Before
After
Check List
yarn run test-unit icon -uyarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.