Elliott: A new approach to check for shipped rpms with product version awareness #1085
Conversation
|
/hold we have a lot of redundant rpms in our -candidate tag that nobody took very close at them. We should re-evaluable this before getting this fixed. |
openshift-ci
bot
added
the
do-not-merge/hold
vfreex
force-pushed
the
elliott-new-find-shipped-logic
branch
from
4267ba4 to
f08fc1e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR requires openshift-eng/art-tools#1085
|
/hold cancel Would like to use a group config option to control whether this new approach should be used. |
openshift-ci
bot
removed
the
do-not-merge/hold
vfreex
changed the title
Currently, we consider an rpm shipped if it has `*-released` Brew tag. Released rpms will be excluded from `find-builds` so they will not be attached to Errata. This has caused a few issues: Some external rpms (e.g. python-zipp) are tagged into both rhaos-4.17-ironic-rhel-9-candidate and rhaos-4.16-ironic-rhel-9-candidate. Once the rpm is shipped to 4.17, we will not be able to ship it to 4.16. With the new approach, we read all candidate tags for an OCP minor version from ocp-build-data erratatool.yml, they consider a rpm is shipped if it has a tag without the -candidate suffix. The feature is not enabled by default unless group config option `feature_gates.product_version_aware_rpm_sweep` is enabled.
vfreex
force-pushed
the
elliott-new-find-shipped-logic
branch
from
f08fc1e to
fa688d1
Compare
|
@vfreex: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Currently, we consider an rpm shipped if it has
*-releasedBrew tag.Released rpms will be excluded from
find-buildsso they will not beattached to Errata.
This has caused a few issues: Some external rpms (e.g. python-zipp) are
tagged into both rhaos-4.17-ironic-rhel-9-candidate and rhaos-4.16-ironic-rhel-9-candidate.
Once the rpm is shipped to 4.17, we will not be able to ship it to 4.16.
With the new approach, we read all candidate tags for an OCP minor
version from ocp-build-data erratatool.yml, they consider a rpm is
shipped if it has a tag without the -candidate suffix.
The feature is not enabled by default unless group config option
feature_gates.product_version_aware_rpm_sweepis enabled.