clean-up

pkg/extension/extension.go

@@ -27,13 +27,11 @@ func NewExtension(product, kind, name string) *Extension {
 func (e *Extension) GetSuite(name string) (*Suite, error) {
 	var suite *Suite
 
-	// Find first matching suite or parent suite
 	for _, s := range e.Suites {
 		if s.Name == name {
 			suite = &s
 			break
 		}
-		// FIXME: handle parents, or just leave that as an origin orchestrated thing?
 	}
 
 	if suite == nil {

pkg/extension/extensiontests/result.go

@@ -1,24 +1,7 @@
 package extensiontests
 
-import "fmt"
-
 func (results ExtensionTestResults) Walk(walkFn func(*ExtensionTestResult)) {
 	for i := range results {
 		walkFn(results[i])
 	}
 }
-
-func (results ExtensionTestResults) CheckOverallResult() error {
-	failed := 0
-
-	results.Walk(func(result *ExtensionTestResult) {
-		if result.Result == ResultFailed && result.Lifecycle == LifecycleBlocking {
-			failed++
-		}
-	})
-
-	if failed > 0 {
-		return fmt.Errorf("%d tests failed", failed)
-	}
-	return nil
-}