[release-4.16] OCPBUGS-43344: Add SDN node subnet gateway IP to host-network address_set #2328

pliurh · 2024-10-24T12:25:33Z

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This is d/s only patch. It's for the SDN live migration scenario.

openshift-ci-robot · 2024-10-24T12:25:39Z

@pliurh: This pull request references Jira Issue OCPBUGS-43604, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-42605 to target a version in 4.17.0, 4.17.z, but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This is d/s only patch. It's for the SDN live migration scenario.

What this PR does and why is it needed

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2024-10-24T12:27:18Z

/cc @npinaeva @trozet

pliurh · 2024-10-24T12:29:33Z

/jira refresh

openshift-ci-robot · 2024-10-24T12:29:38Z

@pliurh: This pull request references Jira Issue OCPBUGS-43604, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2024-10-24T12:30:37Z

/jira refresh

openshift-ci-robot · 2024-10-24T12:30:50Z

@pliurh: This pull request references Jira Issue OCPBUGS-43604, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-42605 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-42605 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2024-10-25T06:45:48Z

/retest

pliurh · 2024-10-28T03:41:42Z

/retest

pliurh · 2024-10-28T13:27:33Z

/retest

pliurh · 2024-10-29T01:53:33Z

/retest

pliurh · 2024-10-30T13:48:14Z

/retest

pliurh · 2024-10-31T03:46:08Z

/retest

trozet

/lgtm
/label backport-risk-assessed

openshift-ci-robot · 2024-11-08T08:27:58Z

/retest-required

Remaining retests: 0 against base HEAD 81cc8ea and 2 for PR HEAD b9f11a7 in total

pliurh · 2024-11-11T03:31:32Z

/retest-required

openshift-ci-robot · 2024-11-11T09:36:54Z

/retest-required

Remaining retests: 0 against base HEAD 81cc8ea and 2 for PR HEAD b9f11a7 in total

openshift-ci-robot · 2024-11-11T13:30:48Z

@pliurh: This pull request references Jira Issue OCPBUGS-43344, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-43343 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-43343 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This is d/s only patch. It's for the SDN live migration scenario.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2024-11-11T13:56:12Z

/hold

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies. Signed-off-by: Peng Liu <[email protected]>

pliurh · 2024-11-12T08:44:00Z

/unhold

zhaozhanqi · 2024-11-12T09:27:43Z

with the latest patch here.
the issue here https://issues.redhat.com/browse/OCPBUGS-43344?focusedId=26040286&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-26040286 already be fixed
/lgtm

openshift-ci · 2024-11-12T09:29:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, trozet, zhaozhanqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-11-12T09:34:04Z

/retest-required

Remaining retests: 0 against base HEAD 81cc8ea and 2 for PR HEAD f10cc79 in total

pliurh · 2024-11-12T13:15:05Z

/retest-required

openshift-ci-robot · 2024-11-12T17:17:14Z

/retest-required

Remaining retests: 0 against base HEAD 81cc8ea and 2 for PR HEAD f10cc79 in total

openshift-ci-robot · 2024-11-13T01:09:42Z

/retest-required

Remaining retests: 0 against base HEAD e07e0d1 and 2 for PR HEAD f10cc79 in total

openshift-ci · 2024-11-13T04:38:44Z

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway	`f10cc79`	link	false	`/test e2e-metal-ipi-ovn-dualstack-local-gateway`
ci/prow/security	`f10cc79`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-11-13T04:42:27Z

@pliurh: Jira Issue OCPBUGS-43344: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43344 has been moved to the MODIFIED state.

In response to this:

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This is d/s only patch. It's for the SDN live migration scenario.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-11-13T05:39:23Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.16.0-202411130503.p0.ge88e6ab.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-11-13T05:57:31Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.16.0-202411130503.p0.ge88e6ab.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-11-13T06:24:32Z

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.16.0-202411130503.p0.ge88e6ab.assembly.stream.el9.
All builds following this will include this PR.

openshift-merge-robot · 2024-11-13T19:18:55Z

Fix included in accepted release 4.16.0-0.nightly-2024-11-13-115002

pliurh · 2024-11-15T02:55:37Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-11-15T02:56:17Z

@pliurh: new pull request created: #2353

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 24, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 24, 2024

openshift-ci bot requested review from npinaeva, trozet, abhat and JacobTanenbaum October 24, 2024 12:27

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 24, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 24, 2024

openshift-ci bot requested a review from anuragthehatter October 24, 2024 12:31

openshift-ci-robot mentioned this pull request Nov 4, 2024

[release-4.16] OCPBUGS-43604: OCPBUGS-42244: Exporting environment varialbe NODE_CNI for live migration openshift/cluster-network-operator#2538

Merged

trozet approved these changes Nov 6, 2024

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 6, 2024

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648 and mffiedler Nov 6, 2024

openshift-ci bot requested a review from zhaozhanqi November 8, 2024 06:49

pliurh changed the title ~~[release-4.16] OCPBUGS-43604: Add SDN node subnet gateway IP to host-network address_set~~ [release-4.16] OCPBUGS-43344: Add SDN node subnet gateway IP to host-network address_set Nov 11, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024

pliurh force-pushed the release-4.16 branch from b9f11a7 to f10cc79 Compare November 12, 2024 05:29

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024

openshift-merge-bot bot merged commit e88e6ab into openshift:release-4.16 Nov 13, 2024
29 of 31 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 15, 2024

[release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set #2353

Open

[release-4.16] OCPBUGS-43344: Add SDN node subnet gateway IP to host-network address_set #2328

[release-4.16] OCPBUGS-43344: Add SDN node subnet gateway IP to host-network address_set #2328

Conversation

pliurh commented Oct 24, 2024 • edited Loading

openshift-ci-robot commented Oct 24, 2024

What this PR does and why is it needed

Which issue(s) this PR fixes

Special notes for reviewers

How to verify it

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?

pliurh commented Oct 24, 2024

pliurh commented Oct 24, 2024

openshift-ci-robot commented Oct 24, 2024

pliurh commented Oct 24, 2024

openshift-ci-robot commented Oct 24, 2024

pliurh commented Oct 25, 2024

pliurh commented Oct 28, 2024

pliurh commented Oct 28, 2024

pliurh commented Oct 29, 2024

pliurh commented Oct 30, 2024

pliurh commented Oct 31, 2024

trozet left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Nov 8, 2024

pliurh commented Nov 11, 2024

openshift-ci-robot commented Nov 11, 2024

openshift-ci-robot commented Nov 11, 2024

pliurh commented Nov 11, 2024

pliurh commented Nov 12, 2024

zhaozhanqi commented Nov 12, 2024

openshift-ci bot commented Nov 12, 2024

openshift-ci-robot commented Nov 12, 2024

pliurh commented Nov 12, 2024

openshift-ci-robot commented Nov 12, 2024

openshift-ci-robot commented Nov 13, 2024

openshift-ci bot commented Nov 13, 2024

openshift-ci-robot commented Nov 13, 2024

openshift-bot commented Nov 13, 2024

openshift-bot commented Nov 13, 2024

openshift-bot commented Nov 13, 2024

openshift-merge-robot commented Nov 13, 2024

pliurh commented Nov 15, 2024

openshift-cherrypick-robot commented Nov 15, 2024

pliurh commented Oct 24, 2024 •

edited

Loading