OCPBUGS-42707: Bump OVN to ovn24.09-24.09.1-10.el9fdp #2390

dceara · 2024-12-11T08:03:10Z

This picks up the following relevant bug fixes:
https://issues.redhat.com/browse/FDP-906
"ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()"
6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding().
ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding().
33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb().
8eaa7d5991 controller: Fix "use after free" issue in statctrl_run().
8579859f51 mac-cache: Properly handle deletion of SB mac_bindings.

https://issues.redhat.com/browse/FDP-752
"ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips"
2a24b03f7f ipam: Do not report error for static assigned IPs.

https://issues.redhat.com/browse/FDP-786
"When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP"
7b00627433 northd: Respect --ecmp-symmetric-reply for single routes.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

dceara · 2024-12-11T08:04:01Z

@trozet @tssurya FDP24.H was released and includes an updated 24.09 version. This PR bumps OVN and picks up OCP relevant fixes listed above.

dceara · 2024-12-11T09:14:03Z

Related upstream bump: ovn-kubernetes/ovn-kubernetes#4887

zshi-redhat · 2024-12-18T09:00:08Z

/test e2e-aws-ovn-fdp-qe

zshi-redhat · 2024-12-18T13:08:08Z

looks like there are two failures about egress IP testing

openshift-extended-test:
total: 52
failures: 2
errors: 0
skipped: 2
failingScenarios:
- "[sig-networking] SDN OVN EgressIP Author:huirwang-ConnectedOnly-Medium-47028-[FdpOvnOvs] After remove EgressIP node tag, EgressIP will failover to other availabel egress nodes. [Serial]"
- "[sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive] [Serial]"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-12-18T12:06:33Z"}
error: failed to execute wrapped command: exit status 1

zshi-redhat · 2024-12-18T13:08:17Z

/test e2e-aws-ovn-fdp-qe

This picks up the following relevant bug fixes: https://issues.redhat.com/browse/FDP-906 "ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()" 6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding(). ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding(). 33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb(). 8eaa7d5991 controller: Fix "use after free" issue in statctrl_run(). 8579859f51 mac-cache: Properly handle deletion of SB mac_bindings. https://issues.redhat.com/browse/FDP-752 "ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips" 2a24b03f7f ipam: Do not report error for static assigned IPs. https://issues.redhat.com/browse/FDP-786 "When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP" 7b00627433 northd: Respect --ecmp-symmetric-reply for single routes. Signed-off-by: Dumitru Ceara <[email protected]>

dceara · 2025-01-21T09:32:44Z

Corresponding upstream bump was merged: ovn-kubernetes/ovn-kubernetes#4887

martinkennelly · 2025-01-21T09:48:03Z

/payload 4.19 nightly blocking

openshift-ci · 2025-01-21T09:48:13Z

@martinkennelly: trigger 14 job(s) of type blocking for the nightly release of OCP 4.19

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance
periodic-ci-openshift-microshift-release-4.19-periodics-e2e-aws-ovn-ocp-conformance-serial
periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf876a70-d7dc-11ef-8bf7-408df14a5228-0

dceara · 2025-01-21T10:20:00Z

[MIRROR] conntrack-tools-1.4.7-2.el9.x86_64.rpm: Curl error (28): Timeout was reached for http://base-4-19-rhel9.ocp.svc/rhel-9-appstream/Packages/c/conntrack-tools-1.4.7-2.el9.x86_64.rpm [Operation too slow. Less than 1000 bytes/sec transferred the last 2 seconds]
[FAILED] libpkgconf-1.7.3-10.el9.x86_64.rpm: No more mirrors to try - All mirrors were already tried without success

Not a real issue with the PR. retesting

dceara · 2025-01-21T10:20:19Z

/retest

dceara · 2025-01-21T10:35:09Z

/test images

dceara · 2025-01-21T13:32:21Z

/test images

dceara · 2025-01-21T14:32:26Z

Image build error unrelated to the PR (again):

 Error: Error downloading packages:
  python3-policycoreutils-3.6-2.1.el9.noarch: Cannot download, all mirrors were already tried without success

/test images

dceara · 2025-01-21T15:14:14Z

/retest

anuragthehatter · 2025-01-21T16:20:06Z

/test e2e-aws-ovn-fdp-qe

trozet

/lgtm

openshift-ci · 2025-01-21T18:25:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dceara, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

trozet · 2025-01-21T23:44:07Z

/label acknowledge-critical-fixes-only

openshift-ci-robot · 2025-01-21T23:46:34Z

@trozet: This pull request references Jira Issue OCPBUGS-42707, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

trozet · 2025-01-21T23:46:49Z

/retest-required

trozet · 2025-01-21T23:49:48Z

/hold

fdp-qe failure:

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2390/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-fdp-qe/1881738575813283840

{  fail [github.com/openshift/openshift-tests-private/test/extended/util/assert.go:30]: Unexpected error:
    <*errors.errorString | 0xc000190160>: 
    case: [sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive]
    error: lr-policy-list was not synced correctly!
    {
        s: "case: [sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive]\nerror: lr-policy-list was not synced correctly!",
    }
occurred}

@anuragthehatter FYI. Remove the hold if you think the failure is acceptable

asood-rh · 2025-01-22T02:36:36Z

/hold

fdp-qe failure:

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2390/pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-fdp-qe/1881738575813283840

{  fail [github.com/openshift/openshift-tests-private/test/extended/util/assert.go:30]: Unexpected error:
    <*errors.errorString | 0xc000190160>: 
    case: [sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive]
    error: lr-policy-list was not synced correctly!
    {
        s: "case: [sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive]\nerror: lr-policy-list was not synced correctly!",
    }
occurred}

@anuragthehatter FYI. Remove the hold if you think the failure is acceptable

/cc @huiran0826 is looking at the failure.

asood-rh · 2025-01-22T02:45:03Z

Cucushift Test results

/logs/artifacts/serial/junit-report:
total 0
cucushift-e2e:
  total: 26
  failures: 0
  errors: 0
  skipped: 2

huiran0826 · 2025-01-22T07:10:54Z

There is one script issue which will be fixed in https://github.com/openshift/openshift-tests-private/pull/22708. And there is also an intermittent known issue https://issues.redhat.com/browse/OCPBUGS-16217 which would cause the case failed.

/unhold

openshift-ci-robot · 2025-01-22T07:42:49Z

/retest-required

Remaining retests: 0 against base HEAD cd2cd1b and 2 for PR HEAD 41eaacf in total

openshift-ci-robot · 2025-01-22T11:47:32Z

/retest-required

Remaining retests: 0 against base HEAD cd2cd1b and 2 for PR HEAD 41eaacf in total

tssurya · 2025-01-22T12:33:21Z

/test qe-perfscale-aws-ovn-small-node-density-cni
/test qe-perfscale-aws-ovn-small-cluster-density
/test qe-perfscale-aws-ovn-medium-node-density-cni
/test qe-perfscale-aws-ovn-medium-cluster-density

trozet · 2025-01-22T21:55:15Z

/override ci/prow/e2e-aws-ovn-serial

openshift-ci · 2025-01-22T21:55:30Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-01-23T01:02:56Z

/retest-required

Remaining retests: 0 against base HEAD cd2cd1b and 2 for PR HEAD 41eaacf in total

openshift-ci-robot · 2025-01-23T05:11:19Z

/retest-required

Remaining retests: 0 against base HEAD cd2cd1b and 2 for PR HEAD 41eaacf in total

openshift-ci · 2025-01-23T07:51:28Z

@dceara: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.18-upgrade-from-stable-4.17-images	`5bde0a8`	link	true	`/test 4.18-upgrade-from-stable-4.17-images`
ci/prow/e2e-aws-ovn-kubevirt	`5bde0a8`	link	false	`/test e2e-aws-ovn-kubevirt`
ci/prow/4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade	`5bde0a8`	link	true	`/test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview	`41eaacf`	link	false	`/test e2e-metal-ipi-ovn-ipv6-techpreview`
ci/prow/security	`41eaacf`	link	false	`/test security`
ci/prow/e2e-openstack-ovn	`41eaacf`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-fdp-qe	`41eaacf`	link	false	`/test e2e-aws-ovn-fdp-qe`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zshi-redhat · 2025-01-23T13:22:29Z

/retest-required

asood-rh · 2025-01-23T13:43:45Z

/label qe-approved

Based on the results of workflow e2e-aws-ovn-fdp-qe

openshift-ci-robot · 2025-01-23T13:43:51Z

@dceara: This pull request references Jira Issue OCPBUGS-42707, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

This picks up the following relevant bug fixes:
https://issues.redhat.com/browse/FDP-906
"ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()"
6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding().
ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding().
33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb().
8eaa7d5991 controller: Fix "use after free" issue in statctrl_run().
8579859f51 mac-cache: Properly handle deletion of SB mac_bindings.

https://issues.redhat.com/browse/FDP-752
"ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips"
2a24b03f7f ipam: Do not report error for static assigned IPs.

https://issues.redhat.com/browse/FDP-786
"When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP"
7b00627433 northd: Respect --ecmp-symmetric-reply for single routes.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

trozet · 2025-01-23T15:14:58Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-01-23T15:15:03Z

@trozet: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-01-23T17:05:37Z

@dceara: Jira Issue OCPBUGS-42707: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#2390

Jira Issue OCPBUGS-42707 has been moved to the MODIFIED state.

In response to this:

This picks up the following relevant bug fixes:
https://issues.redhat.com/browse/FDP-906
"ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()"
6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding().
ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding().
33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb().
8eaa7d5991 controller: Fix "use after free" issue in statctrl_run().
8579859f51 mac-cache: Properly handle deletion of SB mac_bindings.

https://issues.redhat.com/browse/FDP-752
"ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips"
2a24b03f7f ipam: Do not report error for static assigned IPs.

https://issues.redhat.com/browse/FDP-786
"When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP"
7b00627433 northd: Respect --ecmp-symmetric-reply for single routes.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-01-23T17:06:48Z

@trozet: new pull request created: #2424

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-01-23T19:20:52Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.19.0-202501231838.p0.gfcf25ea.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-23T19:35:59Z

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.19.0-202501231838.p0.gfcf25ea.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-23T19:51:02Z

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.19.0-202501231838.p0.gfcf25ea.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot requested review from abhat and trozet December 11, 2024 08:04

dceara force-pushed the bump-ovn24.09-FDP24H branch from 8adf216 to 611f7b2 Compare December 11, 2024 11:04

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024

dceara force-pushed the bump-ovn24.09-FDP24H branch from 611f7b2 to 5bde0a8 Compare December 11, 2024 11:05

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024

dceara force-pushed the bump-ovn24.09-FDP24H branch from 5bde0a8 to 41eaacf Compare January 21, 2025 09:32

trozet approved these changes Jan 21, 2025

View reviewed changes

openshift-ci bot assigned trozet Jan 21, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 21, 2025

openshift-ci bot requested a review from anuragthehatter January 21, 2025 23:46

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 23, 2025

openshift-merge-bot bot merged commit fcf25ea into openshift:master Jan 23, 2025
40 of 44 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 23, 2025

[release-4.18] OCPBUGS-48805: Bump OVN to ovn24.09-24.09.1-10.el9fdp #2424

Open

OCPBUGS-42707: Bump OVN to ovn24.09-24.09.1-10.el9fdp #2390

OCPBUGS-42707: Bump OVN to ovn24.09-24.09.1-10.el9fdp #2390

Conversation

dceara commented Dec 11, 2024

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

dceara commented Dec 11, 2024

dceara commented Dec 11, 2024 • edited Loading

zshi-redhat commented Dec 18, 2024

zshi-redhat commented Dec 18, 2024

zshi-redhat commented Dec 18, 2024

dceara commented Jan 21, 2025

martinkennelly commented Jan 21, 2025

openshift-ci bot commented Jan 21, 2025

dceara commented Jan 21, 2025

dceara commented Jan 21, 2025

dceara commented Jan 21, 2025

dceara commented Jan 21, 2025

dceara commented Jan 21, 2025

dceara commented Jan 21, 2025

anuragthehatter commented Jan 21, 2025

trozet left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 21, 2025

trozet commented Jan 21, 2025

openshift-ci-robot commented Jan 21, 2025

trozet commented Jan 21, 2025

trozet commented Jan 21, 2025

asood-rh commented Jan 22, 2025

asood-rh commented Jan 22, 2025

huiran0826 commented Jan 22, 2025

openshift-ci-robot commented Jan 22, 2025

openshift-ci-robot commented Jan 22, 2025

tssurya commented Jan 22, 2025

trozet commented Jan 22, 2025

openshift-ci bot commented Jan 22, 2025

openshift-ci-robot commented Jan 23, 2025

openshift-ci-robot commented Jan 23, 2025

openshift-ci bot commented Jan 23, 2025 • edited Loading

zshi-redhat commented Jan 23, 2025

asood-rh commented Jan 23, 2025

openshift-ci-robot commented Jan 23, 2025

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

trozet commented Jan 23, 2025

openshift-cherrypick-robot commented Jan 23, 2025

openshift-ci-robot commented Jan 23, 2025

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

openshift-cherrypick-robot commented Jan 23, 2025

openshift-bot commented Jan 23, 2025

openshift-bot commented Jan 23, 2025

openshift-bot commented Jan 23, 2025

dceara commented Dec 11, 2024 •

edited

Loading

openshift-ci bot commented Jan 23, 2025 •

edited

Loading