Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gait10dof18 millard property update #2964

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

carmichaelong
Copy link
Member

@carmichaelong carmichaelong commented Feb 25, 2021

Addresses opensim-org/opensim-models#143, and works around #2954

Brief summary of changes

Update .osim files to use correct Millard properties and update properties such that no log_info messages show up on load.

Testing I've completed

Tests worked locally (including CMC with gait10dof18), and loading into 4.2 GUI does not have log_info messages.

CHANGELOG.md (choose one)

  • updated to provide more information on how to avoid log messages

This change is Reviewable

Copy link
Member

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @carmichaelong

@aymanhab aymanhab merged commit 9970ef3 into master Feb 26, 2021
@aymanhab aymanhab deleted the gait10dof18_millard_property_update branch February 26, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants