Add aws amplify #123
Add aws amplify #123
Conversation
❌ Deploy Preview for grand-clafoutis-85edb2 failed.
|
❌ Deploy Preview for comforting-speculoos-d9e100 failed.
|
|
@AlbertoCasasOrtiz I'm trying to merge/build my latest environment and the build fails because aws-exports is missing, would you be able to pull this branch and use amplify to run it locally? Thanks |
|
@AlbertoCasasOrtiz This is ready for review now, a couple lingering issues though:
Please let me know if you get this branch working in local environment. Thank you |
src/backend/environment_aws.yml
Outdated
| - typing-inspect==0.9.0 | ||
| - urllib3==2.0.2 | ||
| - wrapt==1.15.0 | ||
| prefix: /home/ayman/miniconda3/envs/osv_bend |
There was a problem hiding this comment.
This prefix is pointing to a path in a specific machine.
There was a problem hiding this comment.
Sure, thanks for the find and please remove as we discussed, particularly the aws.yml file is not used by aws altogether
…pport_share_embed
…animations on model change
…o add_aws_amplify
|
@AlbertoCasasOrtiz if the deployment on aws works as expected let me know and I'll review, thanks |
Signed-off-by: Ayman Habib <[email protected]>
|
@aymanhab I tested and login/logout works, but there is a problem with register. When you register an user, it is marked in AWS as unconfirmed, so we should be able to send an email or something similar to users so they can confirm their accounts: https://docs.amplify.aws/javascript/build-a-backend/auth/enable-sign-up/#confirm-sign-up Since we do not have an email or any way of communicating with users set up yet, we could autoconfirm users when created by now, and create an issue to address the user confirmation in the future, |
|
@AlbertoCasasOrtiz Agreed, my view of minimal usable release is a state where users can upload models and share with a link to somebody without login, will eventually consolidate all the various logins somehow |
|
@aymanhab Should be fixed now and allow sign up without needing to confirm from email. I followed this solution. |
Signed-off-by: Ayman Habib <[email protected]>
integrate front and back end into aws amplify, build lambda function from docker file