Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add optional url to viewer Route to allow for arbitrary urls #124

Merged
merged 28 commits into from
Nov 29, 2023
Merged

[WIP] Add optional url to viewer Route to allow for arbitrary urls #124

merged 28 commits into from
Nov 29, 2023

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Nov 7, 2023 •
edited
Loading

This PR allows for passing a URIEncoded URL to the viewer Route so that URLs of the viewer can be shared. Ideally we add options to support:

  • add mini-viewer Route which invokes viewer but with options to:
  • hideControls which hides the left toolbar
  • playAnimations with options to cycle/playfirst/repeat
  • reduce appbar so options that don't belong are hidden
  • exercise the above by adding a 3d window to the readme.md file of the github repo using iframe

aymanhab added 20 commits October 14, 2023 10:57
@aymanhab
change Docker to use aws base machine and introduce environment_aws.yml
426263e
@aymanhab
Move osimConverters package to same folder as lambda_function.py, upd…
f5c3ef1 
…ate converters to return gltf structures rather than files, update call sites accordingly.
@aymanhab
Avoid default behavior of potential writing to same S3 bucket
abf8d48
@aymanhab
Modify views.py to use the latest API where converters return Gltf st…
fac0d46 
…ructure rather than write a file in prep for using a Lambda function to read/write to S3 buckets
@aymanhab
Update Dockerfile to use opensim-python:4.3 as base, refactor functio…
fc7b248 
…n to do conversion
@aymanhab
Fix py package to account for layout on docker machine and place of G…
145b741 
…eometry folder
@aymanhab
Potential entryPoint to unify local/remote deployment. Currently unused
1462a98
@aymanhab
UUse opensim:4.4 instead of 4.3 that had some missing bindings
446bcbd
@aymanhab
Remove debugging lines and dead code
8d71d59
@aymanhab
Add amplify configuration files to repo for now
93ef31c
@aymanhab
Merge branch 'lambda_docker' into add_aws_amplify
bd0a7f8
@aymanhab
minor cleanup and loosen parsing of file extension
1b2f820
@aymanhab
Addd aws-sdk dependencies
17de961
@aymanhab
Remove aws S3Trigger and refactor lambda function to use from API
5543523
@aymanhab
install requests package/module
856ca37
@aymanhab
Add debugging lines
49ee71b
@aymanhab
Allow lambda_function to use s3 bucket directly and remove credentials
594d9c1
@aymanhab
Merge branch 'master' into add_aws_amplify
7e1c4ce
@aymanhab
Add aws-sdk and invoke converter lambda function directly rather than…
badb7f0 
… based on s3 trigger
@aymanhab
Add optional url to viewer Route to allow for arbitrary urls
7f7ed5b
@aymanhab aymanhab changed the title Add optional url to viewer Route to allow for arbitrary urls [WIP] Add optional url to viewer Route to allow for arbitrary urls Nov 7, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2023 •
edited
Loading

❌ Deploy Preview for comforting-speculoos-d9e100 failed.

Name Link
🔨 Latest commit ea019a0
🔍 Latest deploy log https://app.netlify.com/sites/comforting-speculoos-d9e100/deploys/6553109bb48ee0000819f382

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2023 •
edited
Loading

❌ Deploy Preview for grand-clafoutis-85edb2 failed.

Name Link
🔨 Latest commit ea019a0
🔍 Latest deploy log https://app.netlify.com/sites/grand-clafoutis-85edb2/deploys/6553109bd8e93f00082ce929

@aymanhab aymanhab merged commit 657a06c into master Nov 29, 2023
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aymanhab