Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize ColorNodes to pass and interpolate colors on the viewer side #172

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

aymanhab
Copy link
Member

Pass ColorNode for each GeometryPath that embeds the color as a translation, then apply the translation as color within the useFrame callback. The backend side of this is in the opensim-viewer-backend repo, this is the front end which should be harmless if no ColorNode is present

@aymanhab
Copy link
Member Author

Ready for review (front end). Associated gltf file as zip is here that has baked in colors:
walkColors.zip

Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. I tested the walkColors model, and and old model without colors and everything seems to work properly. I can see the colors changing.

@aymanhab aymanhab merged commit 23dc529 into dev Sep 11, 2024
1 check passed
@aymanhab
Copy link
Member Author

Thanks much @AlbertoCasasOrtiz

@aymanhab aymanhab deleted the color_msls_animation branch September 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants