-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dev into master #173
Conversation
Create css file that removes top bar and drawer in modelviewpage.
… output file to download. This change should go along with accompanying update to backend done manually on aws
Modify front end to maintain user id and pass it to backend lambda
CSS defining gui mode loaded dinamically through url param.
Dinamically load css
Removed important, loading only needed css.
Using typescript instead of css file to switch between app and gui mode.
Getting gui param and storing as viewer state
Select camera
Fix cameras
Fixing cameras.
Signed-off-by: Ayman Habib <[email protected]>
Utilize ColorNodes to pass and interpolate colors on the viewer side
❌ Deploy Preview for grand-clafoutis-85edb2 failed.
|
❌ Deploy Preview for comforting-speculoos-d9e100 failed.
|
Per our discussion yesterday, this brings master in sync. with Dev so that new changes can be isolated/tested with better granularity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Just a few comments on the code.
I have tested dev with a few files and everything seems to work fine.
Duplicate file Signed-off-by: Ayman Habib <[email protected]>
I believe I responded to your feedback @AlbertoCasasOrtiz please let me know if we should merge. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything Looks good, I just changed the name of the README_1.md file to README.md.
Thanks much @AlbertoCasasOrtiz 👍 Merging |
Development branch has many changes on it, this merges these changes to master