Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pkcs11 config more generic #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make the pkcs11 config more generic #199

wants to merge 3 commits into from
+703 −1,343

Conversation

vakwetu
Copy link
Contributor

@vakwetu vakwetu commented Jan 13, 2025 •
edited
Loading

Made the pkcs11 more generic so that hopefully we will be able to support many HSMs and configurations without
too many changes.

Jira: https://issues.redhat.com/browse/OSPRH-12972

@openshift-ci openshift-ci bot requested a review from afaranha January 13, 2025 17:17
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vakwetu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vakwetu vakwetu force-pushed the simplify_luna_deploy branch from d035b77 to 6f7cd13 Compare January 13, 2025 17:27
stuggi
stuggi reviewed Jan 14, 2025
View reviewed changes
pkg/barbican/volumes.go
Name: P11ClientDataVolume,
VolumeSource: corev1.VolumeSource{
Secret: &corev1.SecretVolumeSource{
DefaultMode: &config0644AccessMode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 0640 or 0440 since it can have private keys?

pkg/barbican/p11_prep.go Show resolved Hide resolved
api/v1beta1/barbican_webhook.go Show resolved Hide resolved
controllers/barbican_controller.go Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Show resolved Hide resolved
templates/barbican/config/barbican-api-config.json Outdated Show resolved Hide resolved
templates/barbican/config/barbican-api-config.json Outdated Show resolved Hide resolved
templates/barbican/config/barbican-p11-prep-config.json Outdated Show resolved Hide resolved
templates/barbican/config/barbican-p11-prep-config.json Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Show resolved Hide resolved
@vakwetu vakwetu force-pushed the simplify_luna_deploy branch 2 times, most recently from 4f21104 to f3e693b Compare January 15, 2025 15:45
stuggi
stuggi reviewed Jan 15, 2025
View reviewed changes
controllers/barbican_controller.go Show resolved Hide resolved
controllers/barbican_controller.go Outdated Show resolved Hide resolved
controllers/barbican_controller.go Show resolved Hide resolved
controllers/barbicanworker_controller.go Outdated Show resolved Hide resolved
@vakwetu vakwetu force-pushed the simplify_luna_deploy branch 2 times, most recently from 0e3b919 to 4cc913e Compare January 16, 2025 22:34
@vakwetu vakwetu force-pushed the simplify_luna_deploy branch from 4cc913e to 03e16f4 Compare January 20, 2025 21:06
@vakwetu vakwetu changed the title Initial change to simplify the config Make the pkcs11 config more generic Jan 20, 2025
@vakwetu
Initial change to simplify the config
a3b90a7 
Modify the PKCS11 support to make it more generic and hopefully
make it easier to then support different HSM configuration.
@vakwetu
Modify the functional tests for new pkcs11 support
a1fe6b5
@vakwetu vakwetu force-pushed the simplify_luna_deploy branch from 03e16f4 to a1fe6b5 Compare January 21, 2025 04:46
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025 •
edited
Loading

@vakwetu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 20388ec link true /test precommit-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi left review comments

@dmendiza dmendiza Awaiting requested review from dmendiza

@mauricioharley mauricioharley Awaiting requested review from mauricioharley

@afaranha afaranha Awaiting requested review from afaranha

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vakwetu @stuggi