Remove unused 'DeploymentReady' condition from Cinder status

[abays]

The DeploymentReadyCondition condition in the Cinder controller is initialized but then never used. It doesn't interfere with the overall "ready" state calculation because of the way the Cinder CRD's IsReady() function is written. But if it isn't used, we should just drop it.

[abays]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/cinder-operator-build-deploy-tempest e5c45a7 link false /test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

/test cinder-operator-build-deploy-tempest

Doesn't immediately seem related to this change:

Error from server (NotFound): deployments.apps "openstack-operator-controller-manager" not found
+ n=12
+ sleep 10
+ '[' 12 -ge 30 ']'
+ oc get deployment openstack-operator-controller-manager
NAME                                    READY   UP-TO-DATE   AVAILABLE   AGE
openstack-operator-controller-manager   0/1     1            0           5s
+ break
++ oc get subscription openstack-operator -o 'jsonpath={.status.installedCSV}'
+ INSTALLED_CSV=openstack-operator.v0.0.1
+ oc get csv openstack-operator.v0.0.1 -o 'jsonpath={.spec.install.spec.deployments[*].name}'
+ timeout 240 xargs -I '{}' -d ' ' sh -c 'oc wait --for=condition=Available deployment {} --timeout=-1s'
{"component":"entrypoint","error":"wrapped process failed: exit status 124","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2023-11-20T18:43:55Z"}
error: failed to execute wrapped command: exit status 124

[fmount]

unless there are other plans to reuse this variable, the change makes sense
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abays]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment