Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure barbican access #305

Merged

Conversation

ASBishop
Copy link
Contributor

@ASBishop ASBishop commented Dec 6, 2023

Add the [barbican] settings so that all cinder services can access barbican via its internal endpoint. Barbican is already the default key manager.

Jira: OSPRH-1376

Add the [barbican] settings so that all cinder services can access
barbican via its internal endpoint. Barbican is already the default
key manager.

Jira: OSPRH-1376
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and it seems aligned with what we've done in both Glance PR and Nova.

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ASBishop, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d93fb65 into openstack-k8s-operators:main Dec 8, 2023
1 check passed
@ASBishop ASBishop deleted the barbican branch December 8, 2023 18:28
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
…rators/renovate/openstack-k8s-operators

Update openstack-k8s-operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants