Expose bind9 endpoints #253
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
note: it looks like the services are created with a metalLB ip, but I am not sure if we want an endpoint as well ~ > oc get endpoints | grep designate |
pkg/designatebackendbind9/service.go
Outdated
| Namespace: m.Namespace, | ||
| Labels: labels, | ||
| Annotations: map[string]string{ | ||
| "metallb.universe.tf/address-pool": "internalapi", |
There was a problem hiding this comment.
The address pool will need to be configurable.
There was a problem hiding this comment.
Done, I will upload another version.
| services := make([]*corev1.Service, replicas) | ||
|
|
||
| for i := int32(0); i < replicas; i++ { | ||
| podName := fmt.Sprintf("%s-%d", m.Name, i) |
There was a problem hiding this comment.
This might not be correct for a mapping. We'll need to figure that out.
omersch381
force-pushed
the
add_service_per_bind
branch
from
bcd079d to
34fa11f
Compare
|
/retest |
| @@ -78,6 +78,11 @@ type DesignateBackendbind9SpecBase struct { | |||
| // +kubebuilder:validation:Optional | |||
| // StorageRequest | |||
| StorageRequest string `json:"storageRequest"` | |||
|
|
|||
| // +kubebuilder:default="internalapi" | |||
There was a problem hiding this comment.
In retrospect, I don't think this is a good default. It may not be possible to to have a default really. What are your thoughts on leaving it empty and only creating the services if a pool is provided? For testing we might want to try using the ctlplane address pool and see if we can reach the binds that way.
This patch creates series of services and map them to the statefulset members using the podname. Each service has an IP from a metallb pool.
omersch381
force-pushed
the
add_service_per_bind
branch
from
34fa11f to
239491c
Compare
|
@omersch381: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This patch creates series of services and map them to the statefulset members using the podname.
Each service has an IP from a metallb pool.