Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool update job be #269

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Pool update job be #269

wants to merge 2 commits into from
+231 −106

Conversation

beagles
Copy link
Collaborator

@beagles beagles commented Jan 15, 2025

No description provided.

@omersch381
Add pool update job
bce3dab 
This patch adds a designate-manage pool update job, which should be run
every time the pools.yaml file is modified.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beagles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@beagles
Copy link
Collaborator Author

beagles commented Jan 15, 2025

/test all

@beagles beagles force-pushed the pool_update_job_be branch from a136bac to 150f73c Compare January 15, 2025 21:43
@beagles
Copy link
Collaborator Author

beagles commented Jan 15, 2025

/test all

@beagles beagles force-pushed the pool_update_job_be branch from 150f73c to 41924c1 Compare January 15, 2025 23:47
@beagles
Copy link
Collaborator Author

beagles commented Jan 15, 2025

/test all

@beagles beagles force-pushed the pool_update_job_be branch from 41924c1 to c214f7b Compare January 16, 2025 13:55
@beagles
Copy link
Collaborator Author

beagles commented Jan 16, 2025

/test all

@beagles beagles force-pushed the pool_update_job_be branch from c214f7b to 8efff0f Compare January 16, 2025 18:43
@beagles
Copy link
Collaborator Author

beagles commented Jan 16, 2025

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@beagles: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/designate-operator-build-deploy-kuttl 8efff0f link true /test designate-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@beagles
Rearrange method and remove unnecessary code
58412a6 
Also fixes a bind configuration syntax bug.
@beagles beagles force-pushed the pool_update_job_be branch from 8efff0f to 58412a6 Compare January 21, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beagles @omersch381